Work around a locale issue in Ormolu #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise ormolu doesn't work
mdimjasevic
approved these changes
May 21, 2021
* Removes the Data.Qualified.OptionallyQualified data type from types-common
* Refactor: Move Brig.User.Event* to brig-types * Make notification checkers give complete call stack with error in galley legalhold integration tests. * mkApp also returns finalizer for logs * Use real brig event types in galley tests. Co-authored-by: Matthias Fischmann <mf@zerobuzz.net>
* Add legalhold status to user profile * Work around bug in test utils. see https://wearezeta.atlassian.net/browse/SQSERVICES-471 Co-authored-by: Matthias Fischmann <mf@zerobuzz.net>
* Encode golden jsons using prettyEncode for easier diffs * Re-encode golden test jsons so they are pretty * Reformat generated golden tests for easier reviews Reformatting done like this: - Install hindent - Write .hindent.yaml as (note that couple of extensions are missing as hindent doesn't support them yet): ``` indent-size: 2 line-length: 120 force-trailing-newline: true extensions: - BangPatterns - ConstraintKinds - DataKinds - DefaultSignatures - DerivingStrategies - DerivingVia - DeriveFunctor - DeriveGeneric - DeriveTraversable - EmptyCase - FlexibleContexts - FlexibleInstances - FunctionalDependencies - GADTs - InstanceSigs - KindSignatures - LambdaCase - MultiParamTypeClasses - MultiWayIf - NamedFieldPuns - NoImplicitPrelude - OverloadedStrings - PackageImports - PatternSynonyms - PolyKinds - QuasiQuotes - RankNTypes - ScopedTypeVariables - StandaloneDeriving - TemplateHaskell - TupleSections - TypeApplications - TypeFamilies - TypeFamilyDependencies - TypeOperators - UndecidableInstances - ViewPatterns ``` - Run ormolu on the whole project
mdimjasevic
changed the title
|
@arianvp and @pcapriotti , I just updated the PR to use the |
shell.nix
Outdated
| @@ -58,6 +58,7 @@ let | |||
| }; | |||
| in pkgs.mkShell { | |||
| name = "shell"; | |||
| LOCAL_ARCHIVE=${glibcLocales}/lib/locale/locale-archive; # works around https://github.com/tweag/ormolu/issues/38 | |||
There was a problem hiding this comment.
Shouldn't this be pkgs.glibcLocales?
There was a problem hiding this comment.
I am an absolute beginner at Nix. Should I replace "glibcLocales" with "pkgs.glibcLocales"?
There was a problem hiding this comment.
You need to wrap it in quotes and qualify glibcLocales with pkgs.
pcapriotti
previously requested changes
May 25, 2021
|
@pcapriotti attributes of a derivation are exposed as environment variables.
https://nixos.org/manual/nix/unstable/expressions/derivations.html |
Ah, I didn't know that, thanks. |
pcapriotti
requested changes
May 26, 2021
shell.nix
Outdated
| @@ -58,6 +58,7 @@ let | |||
| }; | |||
| in pkgs.mkShell { | |||
| name = "shell"; | |||
| LOCAL_ARCHIVE="${pkgs.glibcLocales}/lib/locale/locale-archive"; # works around https://github.com/tweag/ormolu/issues/38 | |||
There was a problem hiding this comment.
Suggested change
| LOCAL_ARCHIVE="${pkgs.glibcLocales}/lib/locale/locale-archive"; # works around https://github.com/tweag/ormolu/issues/38 | |
| LOCALE_ARCHIVE = "${pkgs.glibcLocales}/lib/locale/locale-archive"; # works around https://github.com/tweag/ormolu/issues/38 |
pcapriotti
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise ormolu doesn't work