Welcome notification bug #3907
Merged
Welcome notification bug #3907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
pcapriotti
force-pushed
the
pcapriotti/welcome-notifications
branch
from
22a64d7 to
346699e
Compare
pcapriotti
force-pushed
the
pcapriotti/welcome-notifications
branch
from
346699e to
ff60411
Compare
stefanwire
approved these changes
Mar 11, 2024
pcapriotti
force-pushed
the
pcapriotti/welcome-notifications
branch
from
adf6dd2 to
106b1a0
Compare
pcapriotti
added a commit
that referenced
this pull request
Mar 11, 2024
* Add failing test reproducing the issue * Only create one welcome notification per user * Add CHANGELOG entry * Lint * Test notifications for both clients
pcapriotti
added a commit
that referenced
this pull request
Mar 11, 2024
* Add failing test reproducing the issue * Only create one welcome notification per user * Add CHANGELOG entry * Lint * Test notifications for both clients
pcapriotti
added a commit
that referenced
this pull request
Mar 11, 2024
* Welcome notification bug (#3907) * Add failing test reproducing the issue * Only create one welcome notification per user * Add CHANGELOG entry * Lint * Test notifications for both clients * Add missing import
echoes-hq
bot
added
the
echoes: unplanned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements collecting welcome notifications by user before sending them to gundeck. Otherwise, gundeck would attempt to store one entry for each client, and one would overwrite the others.
We had already fixed a similar bug for MLS messages (#3610), but neglected to apply a similar fix to welcome messages.
https://wearezeta.atlassian.net/browse/WPB-6852
Checklist
changelog.d