Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport welcome notification fix #3937

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Conversation

pcapriotti
Copy link
Contributor

https://wearezeta.atlassian.net/browse/WPB-6852

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@pcapriotti pcapriotti changed the base branch from develop to q1-2024 March 11, 2024 11:56
* Add failing test reproducing the issue

* Only create one welcome notification per user

* Add CHANGELOG entry

* Lint

* Test notifications for both clients
@pcapriotti pcapriotti force-pushed the q1-welcome-notifications branch from fb69cc4 to 9a881d5 Compare March 11, 2024 12:06
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Mar 11, 2024
@pcapriotti pcapriotti merged commit 1a5d29e into q1-2024 Mar 11, 2024
8 checks passed
@pcapriotti pcapriotti deleted the q1-welcome-notifications branch March 11, 2024 15:10
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants