Adjust flaky test for user deletion in SCIM #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisPenner
changed the title
fisx
approved these changes
Mar 20, 2019
ChrisPenner
force-pushed
the
cp/fix-deletion-tests
branch
from
359b5ae to
3cf6ab4
Compare
| deleteUser_ (Just tok) (Just uid) spar | ||
| !!! const 404 === statusCode -- https://tools.ietf.org/html/rfc7644#section-3.6 |
There was a problem hiding this comment.
I think this should instead wait until a 404 actually happens... otherwise how do we ensure that users actually get deleted?
There was a problem hiding this comment.
Hrmm this is a good point; do you have a suggestion of how to do this cleanly? I want to avoid having a bunch of threadDelays slowing down our tests and making things flaky
There was a problem hiding this comment.
we could use the same retry trick we use elsewhere. we just keep deleting until we get a 404.
grep for retry or Control.Retry.
There was a problem hiding this comment.
(should have thought of that when you asked me, sorry!)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deletion calls out to brig asyncronously (hence the 204) so this test is very flakey and is breaking on CI; there's no guarantee that the user is properly deleted by the second time we call. We could add some threadDelay; but that's just slowing down our test suite and hiding the flakiness.
I prefer instead to just leave double-deletion undefined in the tests; in practice it will 404 unless you call it twice very quickly in which case it will 204 twice which I think is totally fine.
Thoughts @fisx?