Refactor Makefiles to support $DOCKER_USER through all docker build targets #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix invalid build argument for Makefile target docker-intermediate, the build arg 'intermediate' was being used instead of 'builder'. This only fails when using the 'DOCKER_USER' variable with the build as there is a default build argument in the Dockerfile.intermediate.
Add docker-prebuilder target to primary Makefile Add docker build args for 'prebuilder' to builder Makefile target
|
|
jamesbrink
changed the title
fisx
approved these changes
May 13, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add the ability to run custom builds using the
$DOCKER_USERvariables starting at the prebuilder stage, while retaining original functionality of course.For example
DOCKER_USER='james.brink' make docker-prebuilder docker-builder docker-deps docker-intermediate