-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2019 05 13 #756
Merged
Merged
Release 2019 05 13 #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: R4m4n <31612751+R4m4n@users.noreply.github.com>
* Add docs for loadtest exe * Simplify and update create test user script to match loadtest simulations format * Update nginz gpg keys info * Update brig config for docker demo * Change cookie domain for demo * Use `localhost` not IP address for cookie domain or it won't work locally * Allow overriding RTS opts at runtime
* Add Email to UserProfile and friends * Tests asserting email visibility behaviour * Add tests for email visibility for /users/:id * Add EmailVisibility to Options file * Separate server from app in Run * Generalize MonadHttp to work with Session * Use new 'runSession' testing strategy * Add email visibility settings to config files * Port Services to use new Bilge MonadHttp
* Clone the parts of wai-middleware-prometheus that we want to mutate. * Mutate the cloned parts of wai-middleware-prometheus that we cloned. * Reference relevant docs.
it turns out cloning functions that are marked NOINLINE and contain a top-level call to unsafePerformIO is changing behavior of your code. D'OH!
…argets (#755) * Fix build argument for docker-intermediate Fix invalid build argument for Makefile target docker-intermediate, the build arg 'intermediate' was being used instead of 'builder'. This only fails when using the 'DOCKER_USER' variable with the build as there is a default build argument in the Dockerfile.intermediate. * Add make target for docker-prebuilder Add docker-prebuilder target to primary Makefile Add docker build args for 'prebuilder' to builder Makefile target
fisx
approved these changes
May 13, 2019
Is it the right PR number? |
It's not, thanks! (Are you bored?) |
(I'm just subscribed to releases, that's all) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2019-04-09 #756
Documentation changes
Bug fixes
Cannon no longer reports 500s in the prometheus metrics when establishing websocket connections. (#751, #754)
Features
Per-installation flag: Allow displaying emails of users in a team (code from #724, see description in #719)
Internal Changes
Docker image building improvements (#755)
Changes (potentially) requiring action for self-hosters
Config value
setEmailVisibility
must be set in brig's config file (if you're not sure,visible_to_self
is the preferred default)