Skip to content

Create a community-wide contributing guide in the repository#26

Merged
oleg-nenashev merged 7 commits intomainfrom
contributing
Apr 19, 2023
Merged

Create a community-wide contributing guide in the repository#26
oleg-nenashev merged 7 commits intomainfrom
contributing

Conversation

@oleg-nenashev
Copy link
Member

The biggest chunk of #8. Other contributing guidelines like one in https://github.com/wiremock/wiremock will need to be updated to refer to this guide for generic sections.

@oleg-nenashev oleg-nenashev added documentation Improvements or additions to documentation community Community enhancements contributing Issues related to contributing to WireMock labels Apr 13, 2023
To do so, you can either fork and clone the repository and do edits in your branch,
or just use GitHub's web interface for small patches.

### Built-in docs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I suggest we make this section more specific about the API documentation i.e. where it is and how to update it?

And also drop the ref to Javadocs, since we don't really do them at the moment. We should consider whether they're all that useful for a library like this, and if so fix them up a bit before encouraging contributions.

Copy link
Member Author

@oleg-nenashev oleg-nenashev Apr 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomakehurst For Javadoc, we could agree to use https://javadoc.io/doc/com.github.tomakehurst/wiremock as the official location for now. Or I can quickly assemble publishing on https://wiremock.github.io/javadoc if we prefer to keep control in the community

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you feel strongly that we really need them, then let's keep them somewhere under wiremock.org

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created wiremock/wiremock.org#32 for the follow-up, will mention it from the doc

@tomakehurst
Copy link
Member

Aside from the above comments, LGTM.

@oleg-nenashev
Copy link
Member Author

@tomakehurst addressed the comments, PTAL

@oleg-nenashev oleg-nenashev merged commit 945de1b into main Apr 19, 2023
@oleg-nenashev oleg-nenashev deleted the contributing branch April 19, 2023 11:15
@oleg-nenashev oleg-nenashev mentioned this pull request Apr 25, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community Community enhancements contributing Issues related to contributing to WireMock documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants