Feature/wb led disable hue events

[pgasheev]

Это уже исправляли тут #807
Но потом сломали тут https://github.com/wirenboard/wb-mqtt-serial/pull/810/files#diff-08a2944d1f3713c6f4d7b0bb550eaa3d544a6257dcf79c27fa1bc9a5744fa965R1032

Исправляем снова, подробности в тикете https://wirenboard.youtrack.cloud/issue/FW-656#focus=Change-4-142657.0-0.pinned

Summary by CodeRabbit

Release Notes for wb-mqtt-serial v2.152.4

• Bug Fixes

  • Disabled events for RGB Strip Hue on WB-LED and WB-MRGBW-D devices
  • Removed sporadic attribute from multiple channel configurations

• Version Update

  • Package updated from 2.152.3 to 2.152.4

[coderabbitai]

Walkthrough

The pull request introduces version 2.152.4 of the wb-mqtt-serial package, focusing on modifying event handling for RGB Strip Hue in WB-LED and WB-MRGBW-D devices. The primary change involves removing the sporadic attribute from multiple channel configurations in JSON template files. This modification affects how these devices interact with their RGB strip settings, potentially changing their event triggering behavior.

Changes

File	Change Summary
debian/changelog	Version updated from 2.152.3 to 2.152.4
templates/config-wb-led.json.jinja	Removed "sporadic": true from multiple channel definitions including RGB Strip Hue, Saturation, Brightness, and various channel brightness settings
templates/config-wb-mrgbw-d-fw3.json.jinja	Removed "sporadic": true from "RGB Strip Hue" channel configuration

Poem

🐰 A rabbit's tale of LED delight,
Sporadic events now take flight
Channels stripped of their wild ways
Configuration enters calmer days
RGB hues, now tamed and bright! 🌈

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cfb40ac and 0042a83.

📒 Files selected for processing (3)

• debian/changelog (1 hunks)
• templates/config-wb-led.json.jinja (0 hunks)
• templates/config-wb-mrgbw-d-fw3.json.jinja (0 hunks)

💤 Files with no reviewable changes (2)

• templates/config-wb-mrgbw-d-fw3.json.jinja
• templates/config-wb-led.json.jinja

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Codacy Static Code Analysis

🔇 Additional comments (4)

debian/changelog (4)

1-2: Version number follows semantic versioning

The version increment from 2.152.3 to 2.152.4 indicates a patch-level change, which is appropriate for a feature modification that doesn't add new functionality or break compatibility.

---

3-4: Change description is concise and clear

The description clearly states what was changed (disabling events for RGB Strip Hue) and which devices are affected (WB-LED and WB-MRGBW-D).

---

5-5: Changelog entry metadata is properly formatted

The entry includes all required metadata: author name, email, and correctly formatted timestamp.

---

1-5: Verify the impact of disabling events

Since this change affects event handling for RGB Strip Hue, it's important to verify the impact on existing installations.

Run the following script to check for any existing usage patterns:

✅ Verification successful

Template-level change with minimal impact

The change only affects device templates and has no detected impact on existing rules or automations. The modification is well-contained within the template definitions for WB-LED and WB-MRGBW-D devices.

• Found in templates: config-wb-led.json.jinja, config-wb-mrgbw-d-fw3.json.jinja
• No usage detected in rules or custom configurations

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for existing usage of RGB Strip Hue events in configurations and rules
# Expected results: Find any configurations or rules that might be affected by this change

# Search for RGB Strip Hue related configurations
echo "Searching for RGB Strip Hue configurations..."
rg -i "rgb.*strip.*hue" 

# Search for related rules
echo "Searching for related rules..."
fd -t f "rules" --exec rg -i "rgb.*strip.*hue" {}

Length of output: 1591

---

Script:

#!/bin/bash
# Search for implementation details
echo "Searching for event-related code..."
rg -i "events.*rgb.*strip.*hue|rgb.*strip.*hue.*events" -A 5

echo "Searching for recent changes in device handlers..."
rg -i "class.*(WBLed|WBMRGBW)" -A 10

echo "Searching for event configuration..."
ast-grep --pattern 'events = $_'

Length of output: 711

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.