-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/wb led switch mode #861
Conversation
WalkthroughThe pull request updates the Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
debian/changelog
(1 hunks)templates/config-wb-led.json.jinja
(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Codacy Static Code Analysis
🔇 Additional comments (4)
templates/config-wb-led.json.jinja (3)
359-359
: LGTM: Default action now matches switch position.The change ensures that the default action aligns with the physical switch position (0 for "off", 1 for "on"), improving the intuitive behavior of the device.
380-382
: LGTM: Added W4 channel support in RGB+W mode.The addition of value 4 to the enum_switch array enables W4 channel support in RGB+W mode, completing the functionality as intended.
393-395
: LGTM: Consistent W4 channel support across configurations.The addition of value 4 to enum_switch_non_all maintains consistency with the enum_switch changes, ensuring W4 channel support is properly implemented across all configurations.
debian/changelog (1)
1-5
: LGTM! Well-structured changelog entry.The changelog entry follows proper format and provides clear descriptions of the changes that align with the PR objectives.
Co-authored-by: Nikolay Korotkiy <sikmir@disroot.org>
В шаблоне WB-LED поправил несколько проблем для режима выключателя:
Тикет: https://wirenboard.youtrack.cloud/issue/FW-809
Summary by CodeRabbit
New Features
Bug Fixes
Chores