Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/wb led switch mode #861

Merged
merged 7 commits into from
Jan 31, 2025
Merged

Bugfix/wb led switch mode #861

merged 7 commits into from
Jan 31, 2025

Conversation

pgasheev
Copy link
Contributor

@pgasheev pgasheev commented Jan 28, 2025

В шаблоне WB-LED поправил несколько проблем для режима выключателя:

  • дефолтное действие теперь соответствует положению выключателя
  • был пропущен канал W4 в режиме RGB+W

Тикет: https://wirenboard.youtrack.cloud/issue/FW-809

Summary by CodeRabbit

  • New Features

    • Enhanced WB-LED template configuration.
    • Improved input switch action default values.
    • Updated switch mode actions for RGB+W mode, now including the W4 channel.
  • Bug Fixes

    • Corrected default switch state to accurately reflect 'off' and 'on' behaviors.
  • Chores

    • Updated package version to 2.154.2.

@pgasheev pgasheev requested review from a team, KraPete and sikmir as code owners January 28, 2025 14:29
Copy link

coderabbitai bot commented Jan 28, 2025

Walkthrough

The pull request updates the wb-mqtt-serial package to version 2.154.2, focusing on enhancements to the WB-LED template. Key modifications include correcting default values for switch mode actions and incorporating the W4 channel in RGB+W mode. Additionally, the templates/config-wb-led.json.jinja file is modified to adjust default values and enumeration for switch actions, improving configurability and operational behavior.

Changes

File Change Summary
debian/changelog Updated to version 2.154.2, documenting WB-LED template modifications including default switch mode corrections and addition of W4 channel.
templates/config-wb-led.json.jinja - Modified default switch action values to conditionally set 0 or 1 based on switch state.
- Updated enumeration to include value 4, changing [0, 10, 100] to [0, 10, 4, 100] and [0, 10] to [0, 10, 4].

Possibly related PRs

  • Feature/wb led disable hue events #851: This PR modifies the templates/config-wb-led.json.jinja file, which is directly related to the changes made in the main PR regarding the WB-LED template's default values and operational behavior.
  • Add WB-MIR v3 template, update WB-MIR v2 template #825: This PR updates the debian/changelog for the wb-mqtt-serial package, which is relevant but does not directly relate to the specific changes made to the WB-LED template in the main PR.

Suggested reviewers

  • KraPete
  • sikmir
  • dnnik

Poem

🐰 A Rabbit's Ode to Switch Delight 🔌

In bytes and bits, a template's might,
Default states now set just right,
With W4 dancing in the light,
Our LED config takes its flight,
Precision coded, pure and bright!

Hop hop hooray! 🎉


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1cc40d3 and 5b31acd.

📒 Files selected for processing (1)
  • debian/changelog (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • debian/changelog

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6c15549 and 5d95efa.

📒 Files selected for processing (2)
  • debian/changelog (1 hunks)
  • templates/config-wb-led.json.jinja (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Codacy Static Code Analysis
🔇 Additional comments (4)
templates/config-wb-led.json.jinja (3)

359-359: LGTM: Default action now matches switch position.

The change ensures that the default action aligns with the physical switch position (0 for "off", 1 for "on"), improving the intuitive behavior of the device.


380-382: LGTM: Added W4 channel support in RGB+W mode.

The addition of value 4 to the enum_switch array enables W4 channel support in RGB+W mode, completing the functionality as intended.


393-395: LGTM: Consistent W4 channel support across configurations.

The addition of value 4 to enum_switch_non_all maintains consistency with the enum_switch changes, ensuring W4 channel support is properly implemented across all configurations.

debian/changelog (1)

1-5: LGTM! Well-structured changelog entry.

The changelog entry follows proper format and provides clear descriptions of the changes that align with the PR objectives.

debian/changelog Outdated Show resolved Hide resolved
@pgasheev pgasheev requested a review from sikmir January 29, 2025 17:05
@pgasheev pgasheev merged commit d296e71 into master Jan 31, 2025
13 checks passed
@pgasheev pgasheev deleted the bugfix/wb-led-switch-mode branch January 31, 2025 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants