[bug] Shield wires in cable nodes are rendered differently than spline shield wires #125
Comments
As the spline shield wires are rendered as thin tinned wires with black borders, and the shield wires in cable nodes were rendered as a single (bottom) border, they didn't fit well together. The shield wires in cable nodes are now rendered equally as the spline shield wires. The shield wire color is moved into a common definition. This fixes bug wireviz#125.
|
true... personally I like displaying shields as thin black wires to match the line in the node, and to make them appear different from a black/grey regular wire. would that be better? |
|
I will make a change in my PR #126 later today - probably in the evening, and then you can compare. |
|
FYI: In the multicolor wires PR, shields were represented as a thin silver wire... My worry with that is that this offers poor contrast, especially when printing the diagram. While using colors is definitely helpful, I'm trying to make all the WireViz features work even when printed in B&W, and to keep it accessible to colorblind users (hence the explicit color names in the wire nodes), as well as making sure all the relevant information has proper black on white contrast in the first place. |
As the spline shield wires were rendered as tinned wires with black borders, and the shield wires in cable nodes were rendered as a single (bottom) border, they didn't fit well together. Each shield wire is now rendered equally along the spline sections and in cable nodes. If cable.shield is true, they are rendered as thin black wires in the same way as with version 0.1. The new feature is that cable.shield is allowed to contain a two-letter color code to specify a colored shield wire with black borders. The shield wire thickness is not increased, even if the cable has some multi-colored wires that makes all other wires to increase. This fixes bug wireviz#125.
As the spline shield wires were rendered as tinned wires with black borders, and the shield wires in cable nodes were rendered as a single (bottom) border, they didn't fit well together. Each shield wire is now rendered equally along the spline sections and in cable nodes. If cable.shield is true, they are rendered as thin black wires in the same way as before multi-colors were introduced. The new feature is that cable.shield is allowed to contain a two-letter color code to specify a colored shield wire with black borders. The shield wire thickness is not increased, even if the cable has some multi-colored wires that makes all other wires to increase. This fixes bug wireviz#125.
|
@formatc1702 wrote:
I have now updated PR #126 according to your preference. In addition, it was very easy to also allow colored shield wires if the user wants that, by allowing to specify a color in |
I just quickly hacked something because I was messing with the wire representation inside the cable table. It was not meant as a change suggestion. Sorry for the confusion. 😅 |
As the spline shield wires were rendered as tinned wires with black borders, and the shield wires in cable nodes were rendered as a single (bottom) border, they didn't fit well together. Each shield wire is now rendered equally along the spline sections and in cable nodes. If cable.shield is true, they are rendered as thin black wires in the same way as before multi-colors were introduced. The new feature is that cable.shield is allowed to contain a two-letter color code to specify a colored shield wire with black borders. The shield wire thickness is not increased, even if the cable has some multi-colored wires that makes all other wires to increase. This fixes bug #125.
[Current dev branch]: As the spline shield wires are rendered as thin tinned wires with black borders, and the shield wires in cable nodes are rendered as a black single (bottom) border, they don't fit well together, e.g. in tutorial03.png:
The text was updated successfully, but these errors were encountered: