-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Accept optional (and overridable) harness attribute(s) #158
Comments
|
There might be some more metadata fields that could fit into this section.
I don't know if this kind of metadata about the harness should be mixed with rendering parameters such as the originally proposed |
metadata:
title: Main power harness
...
options:
color_mode: HEX
mini_bom_mode: False
connectors:
...
cables:
...
connections:
... |
Maybe my intention wasn't so clear before. The "technical drawing output" should essentially replace/expand the current HTML output. The idea is that a user can optionally specify a HTML template that will be filled with the metadata; otherwise, a very basic HTML output (similar to now) is generated. My hope is to then easily convert the HTML to PDF, so we don't need to deal with another, completely separate PDF output generator.
Splitting Update:
and this would enable using any language for these visible fields as well. |
<h1>{metadata.title}</h1>
{metadata.description}
<h2>Diagram</h2>
{file contents of {filename}.svg}
<h2>Bill of Materials</h2>
{table with BOM}
<h2>Notes</h2>
{metadata.notes} |
Resolves the basic part of wireviz#158.
Resolves the basic part of wireviz#158.
Resolves the basic part of wireviz#158.
Resolves the basic part of wireviz#158.
I am closing this issue after merging #214. The only thing still open is the overriding of options. I plan on opening a separate issue to generalize this discussion. |
There is a
Harness.color_mode
attribute that is not currently possible to specify from the YAML input file, and additional similar attributes might be needed later.How should such an attribute be specified in the YAML input?
or without a section:
or some other way?
What's the recommended way to allow specifying a value for such an attribute in a prepended YAML file, and optionally override the value in the main harness YAML file?
or without a section:
or some other way?
The text was updated successfully, but these errors were encountered: