Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] How to short multiple pins on one connector? #48

Open
azivkovic3l opened this issue Jun 30, 2020 · 14 comments
Open

[feature] How to short multiple pins on one connector? #48

azivkovic3l opened this issue Jun 30, 2020 · 14 comments
Milestone

Comments

@azivkovic3l
Copy link

No description provided.

@formatc1702
Copy link
Collaborator

formatc1702 commented Jun 30, 2020

There is primitive functionality to attach two pins of the same connector. Please see the end of this modified example:

connectors:
  X1:
    type: D-Sub
    subtype: female
    pinout: [DCD, RX, TX, DTR, GND, DSR, RTS, CTS, RI]
  X2:
    type: Molex KK 254
    subtype: female
    pinout: [GND, RX, TX]

cables:
  W1:
    gauge: 0.25 mm2
    length: 0.2
    color_code: DIN
    wirecount: 3
    shield: true

connections:
  -
    - X1: [5,2,3]
    - W1: [1,2,3]
    - X2: [1,3,2]
  -
    - X1: 5
    - W1: s
  - # short pins 6,7,8 together (specifically: short pin 6 to 7 (first column), and pin 7 to 8 (second column)
    - X1: [6,7]
    - X1: [7,8]

See the output below. It's not pretty, so I am open for suggestions on how to best visualize this. I guess there is also a difference between running a wire between two pins, and connectors that allow some other sort of shorting internally.

test

@quotschmacher
Copy link

quotschmacher commented Jul 1, 2020

maybe it would be necessary to specify a starting and ending angle and a width, so that the shortage can be shorter?

edit: a color setting is missing if i'm not mistaking

@azivkovic3l
Copy link
Author

azivkovic3l commented Jul 1, 2020 via email

@formatc1702
Copy link
Collaborator

Yes, I do agree the current implementation is ugly and missing information... any ideas and/or pull requests on this topic are welcome!

@quotschmacher
Copy link

quotschmacher commented Jul 1, 2020

my python is too weak to help i think.
what about a (overriding) color attribtue for the connection? overriding: override the cable color if a cable is used. and an array in preparation for multi-color wires.

connections:
  - color: [RD]
    - Relais1: [6, 12, 18 ]
    - Relais1: [12, 18, 24]

@formatc1702
Copy link
Collaborator

formatc1702 commented Jul 10, 2020

Here's a mockup of what it could look like:
IMG_3700

I'm not sure how easy that would be to represent graphically... I'll think about it.
A possible input syntax could be:

connectors:
  X1:
    pinout: [...]
    internal_shorts:
      - [1,2]
      - [3,5,7]
      - [4,6]

The primitive example from my comment above, with external loops, could be solved in a similar way:

connectors:
  X1:
    pinout: [...]
    external_shorts:
      - [6,7] # exactly 2 pins must be specified, because that's how wires work
      - [7,8]

Only thing missing is a bit of info on what kind of wire to use for the external shorts.

@azivkovic3l
Copy link
Author

I need small help, I'm using your dev branch because of new features that are still not in master. I see that pins shorting feature is moved to version 0.3. Until than, dev branch complains with the following "Exception: X1 is not in cables" when I define that connector X1 must have shorted pins 3 and 10:
- X1: [3,10]
- X1: [10,3]

What is a new syntax for this shorting in dev branch?

@formatc1702
Copy link
Collaborator

formatc1702 commented Oct 20, 2020

Sorry for the super late reply!
In the newly released v0.2, try the following to short pins 3 and 10... it will be displayed as a wire loop between them, and you have no control over the wire appearance/properties, but maybe this helps you.

X1:
  # connector parameters
  loops:
    - [3, 10]

PS: Long explanation:
The way the connections section works right now, is that it is very strict about alternating between connectors and wires, so you can't have X1 (which is a connector) followed by itself.

@dbozec
Copy link

dbozec commented Aug 23, 2022

Hi, I have a small issue with those loops.
On one of my project the loop wire is hidden behind the Wire description table next to the connector
2022-08-23-180007_563x264_scrot
It's not really readable :(

EDIT: Just saw that this is already reported in #286

@formatc1702
Copy link
Collaborator

Yes, I think loops and internal shorts is something we should tackle soon, since a lot of users request this and complain about the current implementation... which is understandable :)

@kvid
Copy link
Collaborator

kvid commented May 4, 2024

@azivkovic3l, @quotschmacher, @dbozec, and others with similar use cases - I added today a suggested work-around for over-sized loops in #286 (comment)

Update: This work-around is no longer needed with v0.4.1 that includes PR #381.

@dbozec
Copy link

dbozec commented Jul 26, 2024

Sorry for late reply @kvid :
your tweak works on simple cables, but can mess with wires in some complex ones :/

@kvid
Copy link
Collaborator

kvid commented Jul 26, 2024

@dbozec wrote:

Sorry for late reply @kvid : your tweak works on simple cables, but can mess with wires in some complex ones :/

Please also try the same (complex) YAML input with the currently latest v0.4.1 that hopefully should improve the output in such use cases (without needing my tweak suggestion).

@dbozec
Copy link

dbozec commented Jul 29, 2024

Great, it's a lot better, thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants