-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Ability to add BOM items within components #50
Comments
This is a very good point, especially once you get to more complicated mixed contact connectors (first example that comes to mind) which need different pin types within one connector. Maybe @Tyler-Ward and @kvid our BOM experts have a suggestion? 😃 It probably makes sense to start with #51 to allow arbitrary manual BOM additions first, which could cover crimps for the time being. I am totally on board for supporting a proper crimp definition in the future, though! |
This sounds like a good idea and probably wouldn't be too hard to add. Doing #51 first sounds sensible and should be relatively easy to do. I can see there being two methods to define the crimps. For single crimp types a string can be set for the crimp part number and internal part number and used for all positions. (might want a flag to turn on/off limiting crimps to only being added for populated positions). With Templating this can allow the crimp to be declared for an entire series of connectors at once e.g. all female Molex KKs. For multiple crimp types we can specify with arrays similar to bundle wires. Will likely also need a field for a crimp description so they can have a useful description in the bom. The array helper function in #62 will help for this. As well as the example above a common example of needing this might be where there are different crimp parts depending on wire gauge. For interest If you want connectors with unusual loadouts I believe it is possible to set up some lemo connectors to have all of the following in one connector, Low voltage, high voltage, coax, fibre-optic and fluid/gas. |
I'm happy to take those on so feel free to assign to me. |
Much appreciated. It seems you have to comment on #51 in order to be eligible for assigning. |
An idea here would be to tag certain items to be used only for pins that are actually populated, others for all pins (qty = pincount), others in custom quantities (like you mentioned, backshells and the like)... perhaps the |
Apologies for the lack of progress on this the last couple of weeks have bee quite busy. rather than the implementation idea suggested above in #50 (comment) integrating crimps into the idea from #51 which supports additional components on parts might be a better soloution rather than having two methods of defining. I have created a potential format for describing these below. by specifying an additional item field a list of additional items can be added to a connector (or wire). For quantity this can either be a number, "pincount" for the number of pins in a connector or "connectioncount" for the number of connections used. To account for items where the connector is made up of constituent parts and doesnt have a main part (anderson powerpoles as an example) i have also added a ignore_in_bom field below that will prevent creation of a line for the connector itself. This might also be usefull for preterminated connectors which will curently generate two lines in the bom (one for the connector and one for the cable). Any thoughts or suggestions on the format addition example below? connectors:
X1:
type: Powerpole
pinout: [GND, VCC]
ignore_in_bom: true
additional_components:
-
type: housing
qty: 1
unit: ea
manufacturer: Anderson
manufacturer_part_number: 1327G6
internal_part_number: powerpole-black
-
type: housing
qty: 1
unit: ea
manufacturer: Anderson
manufacturer_part_number: 1327
internal_part_number: powerpole-red
-
type: crimp
qty: pincount
unit: ea
manufacturer: Anderson
manufacturer_part_number: 1331
internal_part_number: powerpole-crimp-30A
X2:
type: Molex Micro-Fit
subtype: female
pinout: [GND, VCC, A, B, C]
manufacturer_part_number: 436450500
manufacturer: Molex
internal_part_number: MF3.0-5
additional_components:
-
type: crimp
qty: connectioncount
unit: ea
manufacturer: Molex
manufacturer_part_number: 43030-0007
internal_part_number: MF3.0-Crimp
|
The format looks reasonable.
|
for cable
Unit is currently defaulted to none, I just put ea in the example as I wated somthing to fill the field.
I wasnt sure on connection count either anyone else got any better ideas?
For wires/bundle i can think of the following things you might want to multiple quantity by.
Perhaps adding a qty_multiplier or similar field be a better way to do this, that way you can specify somthing like 2cm heatshrink per connection and get a total length out the end.
In the implementation so far the list is created for each connector and then deduplicated. Will take a look at autogenerated conenctors to make sure they are handled correctly.
|
feel free to submit a PR draft with the current state of things so others can find it and have a look! |
How about optionally different entries for each wire/pin? And perhaps also in wire/pin templates and/or cable/connector templates?
Good idea. Unless you consider accepting expressions like
I agree it might be useful to list them in each diagram node in addition to the BOM with the option to hide them individually. |
Would be great to be able to specify the crimps for connectors and for this to be added to the BOM
The text was updated successfully, but these errors were encountered: