Change wire padding behavior #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvid
requested changes
Jul 27, 2020
Addresses #131
formatc1702
force-pushed
the
bugfix/wire-thickness
branch
from
4cd7c1b
to
3853672
Compare
|
I've built in your suggestion. Please let me know if you have any other points, and I'll merge if not :) |
kvid
approved these changes
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #131.
Previously, padding of single-color wires to match thickness of multicolor ones was decided on a per-cable basis.
This PR changes the behavior to a global, per-harness basis; i.e. if any wire in the entire harness is multicolored, and thus will be rendered thicker, all other wires are padded to match.