fix(rendering): allow render instructions to propagate while rendering slots #10316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 708e927 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
ematipico
approved these changes
Mar 5, 2024
packages/astro/playwright.config.js
Outdated
Comment on lines
30
to
39
| projects: [ | ||
| { | ||
| name: 'Chrome Stable', | ||
| use: { | ||
| browserName: 'chromium', | ||
| channel: 'chrome', | ||
| args: ['--use-gl=egl'], | ||
| }, | ||
| }, | ||
| ], |
There was a problem hiding this comment.
I need this to run E2E tests locally. It shouldn't have been committed. I'll undo it.
matthewp
approved these changes
Mar 5, 2024
bluwy
approved these changes
Mar 5, 2024
Merged
peng
added a commit
to peng/astro
that referenced
this pull request
Mar 6, 2024
* main: [ci] release (withastro#10337) Revert bad release (withastro#10336) [ci] release (withastro#10332) add missing changeset (withastro#10335) [ci] set `--tag` on release (withastro#10323) [ci] format add back data loss confirmation handling (withastro#10330) [ci] format fix(rendering): allow render instructions to propagate while rendering slots (withastro#10316) [ci] format fix: fixed an error in the vue component editor (withastro#10293) chore(vercel): update @vercel/nft (withastro#10305) Update turbo test dependsOn (withastro#10329) Add minimal @astrojs/db readme (withastro#10331)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
client:only.RenderDestination-RenderInstancesystem makes sure that while things execute out of sequence, they get "stringified" in sequence.SlotStringuntouched.Testing
Docs