[ci] set --tag on release
#10323
Merged
[ci] set --tag on release
#10323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bluwy
reviewed
Mar 5, 2024
FredKSchott
added a commit
that referenced
this pull request
Mar 6, 2024
This reverts commit 50215ae.
Merged
FredKSchott
added a commit
that referenced
this pull request
Mar 6, 2024
peng
added a commit
to peng/astro
that referenced
this pull request
Mar 6, 2024
* main: [ci] release (withastro#10337) Revert bad release (withastro#10336) [ci] release (withastro#10332) add missing changeset (withastro#10335) [ci] set `--tag` on release (withastro#10323) [ci] format add back data loss confirmation handling (withastro#10330) [ci] format fix(rendering): allow render instructions to propagate while rendering slots (withastro#10316) [ci] format fix: fixed an error in the vue component editor (withastro#10293) chore(vercel): update @vercel/nft (withastro#10305) Update turbo test dependsOn (withastro#10329) Add minimal @astrojs/db readme (withastro#10331)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
main,next, and1-legacy/2-legacy/3-legacybranches3-legacy, it was published tolateston NPM! Thankfully we released frommainshortly thereafter, but it could be annoying to debug if we forget to do that in the future.Testing
Contrary to my typical YOLO approach, I actually minimized this workflow and tested it in a private repo. Everything works as expected!
Docs
Currently, our actions are super undocumented. Currently attempting to kick off an effort to get more of these decisions documented, but until then, code comments should suffice.