Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an error message when Actions throws in setup #11886

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Aug 30, 2024

Changes

  • Actions throws in astro:config:done if the output is static. This change makes it so that the error surfaces to the user like it should.

Testing

Did so manually looks like:

ActionsWithoutServerOutputError: Actions enabled without setting a server build output. A server is required to create callable backend functions. To deploy routes to a server, add a server adapter to your astro config.

Docs

Bug fix

Copy link

changeset-bot bot commented Aug 30, 2024

🦋 Changeset detected

Latest commit: a164346

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 30, 2024
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @matthewp!

.changeset/many-turtles-tie.md Outdated Show resolved Hide resolved
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
@florian-lefebvre
Copy link
Member

Why isn't the error surfaced without this change?

@matthewp matthewp merged commit 7ff7134 into main Sep 3, 2024
13 checks passed
@matthewp matthewp deleted the sync-failure-actions branch September 3, 2024 13:45
@astrobot-houston astrobot-houston mentioned this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants