Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an error message when Actions throws in setup #11886

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Provide an error message when Actions throws in setup #11886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4b52bc
Provide an error message when Actions throws in setup
matthewp Aug 30, 2024
a164346
Update .changeset/many-turtles-tie.md
matthewp Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/many-turtles-tie.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'astro': patch
---

Fixes a missing error message when actions throws during `astro sync`
1 change: 1 addition & 0 deletions packages/astro/src/core/logger/core.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ export type LoggerLabel =
| 'middleware'
| 'preferences'
| 'redirects'
| 'sync'
| 'toolbar'
| 'assets'
| 'env'
Expand Down
14 changes: 13 additions & 1 deletion packages/astro/src/core/sync/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,19 @@ export default async function sync(
settings,
logger,
});
await runHookConfigDone({ settings, logger });

// Run `astro:config:done`
// Actions will throw if there is misconfiguration, so catch here.
try {
await runHookConfigDone({ settings, logger });
} catch(err) {
if(err instanceof Error) {
const errorMessage = err.toString();
logger.error('sync', errorMessage);
}
throw err;
}

return await syncInternal({ settings, logger, fs, force: inlineConfig.force });
}

Expand Down
Loading