-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move image()
to be passed as part of schema
#6703
Conversation
…ily instead of clumsily
🦋 Changeset detectedLatest commit: cbfbe3f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some callouts on documentation. Couldn't image
ine our internals would get this simple with the change!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new flow looks great 👍
!preview schema-image |
|
!preview schema-image |
|
This PR is blocked because it contains a |
Co-authored-by: Ben Holmes <hey@bholmes.dev>
This PR is blocked because it contains a |
Changes
As the title says, this moves
image()
to be provided throughschema
, like suchschema: ({image}) => z.object({...})
instead of something you import fromastro:content
. This has fairly consequential benefits on our end, as we can now directly pass information about the current entry to schema instead of trying to clumsily patch it.Additionally, since this doesn't rely on clumsy patches anymore:
Testing
Tests still pass!
Docs
withastro/docs#2961