Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use moduleResolution: 'node16' #7787

Closed
wants to merge 2 commits into from
Closed

Use moduleResolution: 'node16' #7787

wants to merge 2 commits into from

Conversation

Princesseuh
Copy link
Member

@Princesseuh Princesseuh commented Jul 24, 2023 •
edited
Loading

Changes

Blocked by vitejs/vite#13947

#7780 made it so we use moduleResolution: 'bundler', this is mostly fine but since we still require extensions in the runtime, it's better for us to use moduleResokution: 'node16' instead. However, this has, a lot of requirements. This PR attempts to do it

Testing

Tests should pass!

Docs

N/A

@Princesseuh Princesseuh requested a review from a team as a code owner July 24, 2023 18:52
@changeset-bot
Copy link

changeset-bot bot commented Jul 24, 2023

⚠️ No Changeset found

Latest commit: 9959899

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Princesseuh Princesseuh marked this pull request as draft July 24, 2023 18:52
@github-actions github-actions bot added feat: markdown Related to Markdown (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: preact Related to Preact (scope) pkg: solid Related to Solid (scope) pkg: integration Related to any renderer integration (scope) pkg: create-astro Related to the `create-astro` package (scope) pkg: astro Related to the core `astro` package (scope) labels Jul 24, 2023
bluwy
bluwy reviewed Jul 25, 2023
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the Vite issue, the changes looks good to me. Thanks for tackling this!

.vscode/settings.json Show resolved Hide resolved
@Princesseuh Princesseuh mentioned this pull request Jul 25, 2023
Merged
9 tasks
@ematipico ematipico force-pushed the next branch 5 times, most recently from d7ce3af to 0676583 Compare August 1, 2023 07:29
@bluwy
Copy link
Member

bluwy commented Aug 1, 2023

Not sure if Vite is the only blocker for node16, but it has been fixed and released in 4.4.7

@ematipico ematipico force-pushed the next branch 2 times, most recently from 77ab4bb to 7822777 Compare August 1, 2023 15:01
@bluwy bluwy mentioned this pull request Aug 2, 2023
Merged
@ematipico ematipico force-pushed the next branch 2 times, most recently from c19adcd to 70f34f5 Compare August 8, 2023 10:04
@Princesseuh
Copy link
Member Author

Closing this, will have to restart from scratch pretty much

@Princesseuh Princesseuh deleted the feat/moduleResolution-16 branch March 1, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy left review comments

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
feat: markdown Related to Markdown (scope) pkg: astro Related to the core `astro` package (scope) pkg: create-astro Related to the `create-astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: preact Related to Preact (scope) pkg: solid Related to Solid (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Princesseuh @bluwy @ematipico