Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18nIgnore] remove await from import.meta.glob() #10332

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Conversation

sarah11918
Copy link
Member

@sarah11918 sarah11918 commented Dec 10, 2024

Changes all occurrences in all languages of await import.meta.glob('*', { eager: true }); to remove await as it is not needed.

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Dec 10, 2024
Copy link

netlify bot commented Dec 10, 2024

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit a010971
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6758a7d5375ed90008a485a1
😎 Deploy Preview https://deploy-preview-10332--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Dec 10, 2024

Lunaria Status Overview

🌑 This pull request will not trigger status changes.

Learn more

Lunaria automatically ignores changes on specific PRs by adding a ignored keyword in its title. Found: i18nIgnore.

You can change this by either removing the keyword above from the PR's title, or modifying the ignoreKeywords property in your Lunaria configuration file.

Tracked Files

Note

The notes below indicate what would happen if the pull request is merged when triggering status changes. Since a ignored keyword was found in the PR's title, the status changes indicated below won't be applied.

File Note
en/guides/integrations-guide/mdx.mdx Source changed, localizations will be marked as outdated.
en/guides/markdown-content.mdx Source changed, localizations will be marked as outdated.
en/guides/migrate-to-astro/from-create-react-app.mdx Source changed, localizations will be marked as outdated.
en/guides/migrate-to-astro/from-gatsby.mdx Source changed, localizations will be marked as outdated.
en/guides/migrate-to-astro/from-nextjs.mdx Source changed, localizations will be marked as outdated.
en/guides/routing.mdx Source changed, localizations will be marked as outdated.
en/reference/api-reference.mdx Source changed, localizations will be marked as outdated.
en/tutorial/5-astro-api/1.mdx Source changed, localizations will be marked as outdated.
en/tutorial/5-astro-api/2.mdx Source changed, localizations will be marked as outdated.
en/tutorial/5-astro-api/3.mdx Source changed, localizations will be marked as outdated.
en/tutorial/6-islands/4.mdx Source changed, localizations will be marked as outdated.
fr/guides/integrations-guide/mdx.mdx Localization changed, will be marked as complete.
fr/guides/markdown-content.mdx Localization changed, will be marked as complete.
fr/guides/routing.mdx Localization changed, will be marked as complete.
ko/guides/imports.mdx Localization changed, will be marked as complete.
ko/guides/integrations-guide/mdx.mdx Localization changed, will be marked as complete.
ko/guides/markdown-content.mdx Localization changed, will be marked as complete.
ko/guides/migrate-to-astro/from-create-react-app.mdx Localization changed, will be marked as complete.
ko/guides/migrate-to-astro/from-gatsby.mdx Localization changed, will be marked as complete.
ko/guides/migrate-to-astro/from-nextjs.mdx Localization changed, will be marked as complete.
ko/guides/routing.mdx Localization changed, will be marked as complete.
ko/reference/api-reference.mdx Localization changed, will be marked as complete.
ko/tutorial/5-astro-api/1.mdx Localization changed, will be marked as complete.
ko/tutorial/5-astro-api/2.mdx Localization changed, will be marked as complete.
ko/tutorial/5-astro-api/3.mdx Localization changed, will be marked as complete.
ko/tutorial/6-islands/4.mdx Localization changed, will be marked as complete.
zh-cn/guides/integrations-guide/mdx.mdx Localization changed, will be marked as complete.
zh-cn/guides/markdown-content.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except another await that seems useless, and the other examples using Object.values do not have await in front.

Co-authored-by: Armand Philippot <git@armand.philippot.eu>
@sarah11918
Copy link
Member Author

Thank you for catching these!

ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Dec 10, 2024
@sarah11918 sarah11918 merged commit eb63196 into main Dec 10, 2024
10 checks passed
@sarah11918 sarah11918 deleted the sarah-await branch December 10, 2024 20:50
thomasbnt added a commit that referenced this pull request Dec 11, 2024
* i18n(fr): update all the `migrate-to` guides

Signed-off-by: Armand Philippot <git@armand.philippot.eu>

* i18n(fr): update `guides/imports.mdx`

See #9240, #10140, #10310 and #10315

* farewell `Astro.glob`

* fix wrong locale

* fix bold text

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>

* remove useless await

see #10332

---------

Signed-off-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>
thomasbnt added a commit to thomasbnt/docs that referenced this pull request Dec 11, 2024
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Dec 11, 2024
thomasbnt added a commit that referenced this pull request Dec 11, 2024
* i18n(fr): update `tutorial/*`

See #9240, #10223, #10332 and #10342

* missing translation

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>

---------

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>
thomasbnt added a commit that referenced this pull request Dec 11, 2024
* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Err tab

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Remove <reference... L116 in netlify

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Remove "côté serveur" L14 in solid-js

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Remove "squoosh" L190 in vercel

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Remove "<reference..." L389 in vercel

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): remove `await` from `import.meta.glob()` from #10332

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): content loader configuration from #10187 (the link at L101 in mdx.mdx file not working)

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): content loader configuration from #10187 (the link at L101 in mdx.mdx file not working)

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Note for myself, mdx.mdx line 101 : When content-collections will be updated, put this text with good link

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): L237 in vercel.mdx "#astrorequest"

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

---------

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Dec 16, 2024
thomasbnt added a commit that referenced this pull request Dec 17, 2024
* i18n(fr): update `api-reference.mdx`

See #9240, #10167 and #10332

* fix missing locale update in a link `en` > `fr`

* fix links in up-to-date files

* fix outdated anchors and a heading in `api-reference`

* update `guides/endpoints.mdx`

* update `guides/middleware.mdx`

* fix last link

* fix typo

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>

---------

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants