-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[i18nIgnore] remove await
from import.meta.glob()
#10332
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lunaria Status Overview🌑 This pull request will not trigger status changes. Learn moreLunaria automatically ignores changes on specific PRs by adding a ignored keyword in its title. Found: You can change this by either removing the keyword above from the PR's title, or modifying the Tracked FilesNote The notes below indicate what would happen if the pull request is merged when triggering status changes. Since a ignored keyword was found in the PR's title, the status changes indicated below won't be applied.
Warnings reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except another await
that seems useless, and the other examples using Object.values
do not have await
in front.
src/content/docs/en/guides/migrate-to-astro/from-create-react-app.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/ko/guides/migrate-to-astro/from-create-react-app.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Thank you for catching these! |
* i18n(fr): update all the `migrate-to` guides Signed-off-by: Armand Philippot <git@armand.philippot.eu> * i18n(fr): update `guides/imports.mdx` See #9240, #10140, #10310 and #10315 * farewell `Astro.glob` * fix wrong locale * fix bold text Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com> * remove useless await see #10332 --------- Signed-off-by: Armand Philippot <git@armand.philippot.eu> Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
* i18n(fr): Update `guides/integrations-guide/*`from #9240 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update `guides/integrations-guide/*`from #9240 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update `guides/integrations-guide/*`from #9240 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update `guides/integrations-guide/*`from #9240 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update `guides/integrations-guide/*`from #9240 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update `guides/integrations-guide/*`from #9240 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update `guides/integrations-guide/*`from #9240 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update `guides/integrations-guide/*`from #9240 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update `guides/integrations-guide/*`from #9240 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update `guides/integrations-guide/*`from #9240 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update `guides/integrations-guide/*`from #9240 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update `guides/integrations-guide/*`from #9240 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update `guides/integrations-guide/*`from #9240 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update `guides/integrations-guide/*`from #9240 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update `guides/integrations-guide/*`from #9240 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update `guides/integrations-guide/*`from #9240 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update `guides/integrations-guide/*`from #9240 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update `guides/integrations-guide/*`from #9240 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update `guides/integrations-guide/*`from #9240 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update `guides/integrations-guide/*`from #9240 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update `guides/integrations-guide/*`from #9240 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update `guides/integrations-guide/*`from #9240 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update `guides/integrations-guide/*`from #9240 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update `guides/integrations-guide/*`from #9240 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update `guides/integrations-guide/*`from #9240 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update `guides/integrations-guide/*`from #9240 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update `guides/integrations-guide/*`from #9240 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update `guides/integrations-guide/*`from #9240 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update `guides/integrations-guide/*`from #9240 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update `guides/integrations-guide/*`from #9240 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update `guides/integrations-guide/*`from #9240 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Err tab Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Remove <reference... L116 in netlify Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Remove "côté serveur" L14 in solid-js Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Remove "squoosh" L190 in vercel Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Remove "<reference..." L389 in vercel Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): remove `await` from `import.meta.glob()` from #10332 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): content loader configuration from #10187 (the link at L101 in mdx.mdx file not working) Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): content loader configuration from #10187 (the link at L101 in mdx.mdx file not working) Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Note for myself, mdx.mdx line 101 : When content-collections will be updated, put this text with good link Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): L237 in vercel.mdx "#astrorequest" Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> --------- Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> Co-authored-by: Armand Philippot <git@armand.philippot.eu>
* i18n(fr): update `api-reference.mdx` See #9240, #10167 and #10332 * fix missing locale update in a link `en` > `fr` * fix links in up-to-date files * fix outdated anchors and a heading in `api-reference` * update `guides/endpoints.mdx` * update `guides/middleware.mdx` * fix last link * fix typo Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com> --------- Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>
Changes all occurrences in all languages of
await import.meta.glob('*', { eager: true });
to removeawait
as it is not needed.