Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] update shiki config for transformers API #6402

Merged
merged 3 commits into from
Jan 18, 2024
Merged

[docs] update shiki config for transformers API #6402

merged 3 commits into from
Jan 18, 2024

Conversation

blackmann
Copy link
Contributor

Description (required)

An update has been made to shikiConfig's API.

⚠️ For some reason when I save the file, it is reformatted with other lines losing a trailing space.

Related issues & labels (optional)

  • Closes #
  • Suggested label:

For Astro version: 4.2. See astro PR #9643.

@vercel Vercel
Copy link

vercel bot commented Jan 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jan 18, 2024 11:19am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Visit Preview Jan 18, 2024 11:19am

@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@blackmann blackmann mentioned this pull request Jan 15, 2024
Merged
sarah11918
sarah11918 reviewed Jan 15, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this to the docs. The feature looks really useful!

I think we can tighten this up, but otherwise, this is just what we needed. Welcome to Team docs! 🥳

src/content/docs/en/guides/markdown-content.mdx Outdated Show resolved Hide resolved
@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! labels Jan 15, 2024
@sarah11918 sarah11918 added this to the 4.2.0 milestone Jan 15, 2024
sarah11918
sarah11918 approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ready for 4.2 release!

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Jan 17, 2024
@sarah11918 sarah11918 merged commit 805d23c into withastro:main Jan 18, 2024
7 of 8 checks passed
@huyikai huyikai mentioned this pull request Jan 19, 2024
Merged
@jsparkdev jsparkdev mentioned this pull request Jan 20, 2024
Merged
yanthomasdev added a commit that referenced this pull request Jan 25, 2024
@McFlyPartages @thomasbnt @yanthomasdev
i18n(fr): Update translation for all outdated files (#6616)
7405875 
* Update with PR #6440

* Update with PR #6386

* Up with PR #6532

* Up with PR #6436

* Upd Just for Lunaria with PR #6444

* Up with PR #6402

* Up with PR #6548

* Up with PR #6430

* Up with PR #6469

* Up with PR #6522

* Up with PR #6272

* Update src/content/docs/fr/editor-setup.mdx

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>

* Update src/content/docs/fr/reference/publish-to-npm.mdx

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>

---------

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
ematipico pushed a commit that referenced this pull request Jan 26, 2024
@blackmann @sarah11918 @ematipico
[docs] update shiki config for transformers API (#6402)
2b9bd91 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
ematipico pushed a commit that referenced this pull request Jan 26, 2024
@McFlyPartages @thomasbnt
@yanthomasdev @ematipico
i18n(fr): Update translation for all outdated files (#6616)
97375e3 
* Update with PR #6440

* Update with PR #6386

* Up with PR #6532

* Up with PR #6436

* Upd Just for Lunaria with PR #6444

* Up with PR #6402

* Up with PR #6548

* Up with PR #6430

* Up with PR #6469

* Up with PR #6522

* Up with PR #6272

* Update src/content/docs/fr/editor-setup.mdx

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>

* Update src/content/docs/fr/reference/publish-to-npm.mdx

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>

---------

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees
No one assigned
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@blackmann @astrobot-houston @sarah11918