Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(en): update editor-setup #6532

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Conversation

DerTimonius
Copy link
Contributor

Description (required)

Small change to the english version of the editor-setup.mdx file, related to the update of the german translation in #6362

Copy link

vercel bot commented Jan 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jan 22, 2024 7:44pm

@@ -28,7 +28,7 @@ import ReadMore from '~/components/ReadMore.astro';

Initial support for Astro landed in WebStorm 2023.1. You can install the official plugin through [JetBrains Marketplace](https://plugins.jetbrains.com/plugin/20959-astro) or by searching for "Astro" in the IDE's Plugins tab. This plugin includes features like syntax highlighting, code completion, and formatting, and plans to add even more advanced features in the future. It is also available to all other [JetBrains IDEs with JavaScript support](https://www.jetbrains.com/products/#lang=js&type=ide).

JetBrains' upcoming [Fleet IDE](https://www.jetbrains.com/fleet/) includes language server support and will be able to use the official Astro tooling.
JetBrains' [Fleet IDE](https://www.jetbrains.com/fleet/) includes language server support and uses the official Astro tooling.
Copy link
Member

@Princesseuh Princesseuh Jan 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not really true, Fleet still requires a plugin (that doesn't exist) / some custom configuration, unlike options described before that just works out of the box. It's just intended to be compatible with the underlying technology we use and so developing a plugin is at least possible

Though, I'm not even sure if its LSP support is fully released yet.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK this is causing me way too much grief. FLEET IS DEAD TO ME.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm all for getting out the pitchforks 😄

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DerTimonius ! Given Erika's comment, let's remove this entirely, and you can update the German to also delete.

src/content/docs/en/editor-setup.mdx Outdated Show resolved Hide resolved
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yanthomasdev yanthomasdev merged commit 87a6c5a into withastro:main Jan 22, 2024
6 checks passed
yanthomasdev added a commit that referenced this pull request Jan 25, 2024
* Update with PR #6440

* Update with PR #6386

* Up with PR #6532

* Up with PR #6436

* Upd Just for Lunaria with PR #6444

* Up with PR #6402

* Up with PR #6548

* Up with PR #6430

* Up with PR #6469

* Up with PR #6522

* Up with PR #6272

* Update src/content/docs/fr/editor-setup.mdx

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>

* Update src/content/docs/fr/reference/publish-to-npm.mdx

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>

---------

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
ematipico pushed a commit that referenced this pull request Jan 26, 2024
* update editor-setup

* Update src/content/docs/en/editor-setup.mdx

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

---------

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
ematipico pushed a commit that referenced this pull request Jan 26, 2024
* Update with PR #6440

* Update with PR #6386

* Up with PR #6532

* Up with PR #6436

* Upd Just for Lunaria with PR #6444

* Up with PR #6402

* Up with PR #6548

* Up with PR #6430

* Up with PR #6469

* Up with PR #6522

* Up with PR #6272

* Update src/content/docs/fr/editor-setup.mdx

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>

* Update src/content/docs/fr/reference/publish-to-npm.mdx

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>

---------

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants