Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(i18n): manual routing #7749

Merged
merged 14 commits into from
Apr 10, 2024
Merged

feat(i18n): manual routing #7749

merged 14 commits into from
Apr 10, 2024

Conversation

ematipico
Copy link
Member

Description (required)

Closes PLT-1921

This PR adds documentation for the upcoming i18n manual routing.

For Astro version: 4.6.0. See astro PR #10193.

@vercel Vercel
Copy link

vercel bot commented Apr 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Apr 10, 2024 10:00pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Apr 10, 2024 10:00pm

@sarah11918 sarah11918 added this to the 4.6.0 milestone Apr 3, 2024
@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! labels Apr 3, 2024
@ematipico ematipico mentioned this pull request Apr 8, 2024
Merged
ematipico
ematipico commented Apr 8, 2024
View reviewed changes
Copy link
Member Author

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The manual configuration paragraph looks good to me

@sarah11918 sarah11918 mentioned this pull request Apr 8, 2024
Closed
yanthomasdev
yanthomasdev reviewed Apr 8, 2024
View reviewed changes
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far, found just a small typo

@sarah11918 @yanthomasdev
fix typo
5a204ba 
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Apr 10, 2024
@sarah11918
Copy link
Member

Woo! Links passed! Gonna need to i18nIgnore this one, unless @yanthomasdev wants something done differently here!

@yanthomasdev
Copy link
Member

yanthomasdev commented Apr 10, 2024 •
edited
Loading

Woo! Links passed! Gonna need to i18nIgnore this one, unless @yanthomasdev wants something done differently here!

Not i18nIgnore! We gonna need a tracker directive for this one.

Please paste this into the merge commit body FOR THE FINAL 4.6 BRANCH:

@lunaria-ignore:src/content/docs/!(en)/reference/configuration-reference.mdx;src/content/docs/!(en)/guides/internationalization.mdx
@tracker-minor:src/content/docs/!(en)/reference/configuration-reference.mdx;src/content/docs/!(en)/guides/internationalization.mdx;./src/content/docs/!(en)/reference/configuration-reference.mdx;./src/content/docs/!(en)/guides/internationalization.mdx

@sarah11918
Copy link
Member

Thanks @yanthomasdev ! Fortunately, this i18n page was never i18n:true in the first place, so the disruption to the MAIN page changed here is minimal. (But, KO translated it anyway?) So, I'll also convert this to true when it's merged. UNLEASH THE TRANSLATORS!

@sarah11918 sarah11918 mentioned this pull request Apr 10, 2024
Merged
@sarah11918 sarah11918 changed the base branch from main to 4.6.0 April 10, 2024 21:50
@sarah11918 sarah11918 merged commit fa276a5 into 4.6.0 Apr 10, 2024
2 of 3 checks passed
@sarah11918 sarah11918 deleted the feat/i18n-manual-routing branch April 10, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 left review comments

@yanthomasdev yanthomasdev yanthomasdev left review comments

Assignees
No one assigned
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ematipico @sarah11918 @yanthomasdev