Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.6.0 minor docs update #7846

Merged
merged 10 commits into from
Apr 11, 2024
Merged

4.6.0 minor docs update #7846

merged 10 commits into from
Apr 11, 2024

Conversation

sarah11918
Copy link
Member

@sarah11918 sarah11918 commented Apr 10, 2024 •
edited
Loading

Co-authored-by: sarah11918 sarah11918@users.noreply.github.com

Description (required)

This updates the docs for the 4.6 minor from the following PRs:

#7844
#7845
#7720
#7814
#7749
#7838

astrobot-houston and others added 4 commits April 10, 2024 18:32
@astrobot-houston @sarah11918
ci: update error reference docs (#7844)
6c4da0e 
Co-authored-by: sarah11918 <sarah11918@users.noreply.github.com>
@astrobot-houston @sarah11918
ci: update reference docs (#7845)
0910fd8 
Co-authored-by: sarah11918 <sarah11918@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@mingjunlu @sarah11918
feat: mention that the user can change the placement of the dev toolb…
2c4ae4a 
…ar (#7720)

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@fshafiee @sarah11918
Update the list of acceptable cookie options for Astro.cookies.delete (…
7828b8f 
…#7814)

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@sarah11918 sarah11918 added merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! labels Apr 10, 2024
@sarah11918
Copy link
Member Author

Lunaria command for final merge:

@lunaria-ignore:src/content/docs/!(en)/reference/configuration-reference.mdx;src/content/docs/!(en)/guides/internationalization.mdx
@tracker-minor:src/content/docs/!(en)/reference/configuration-reference.mdx;src/content/docs/!(en)/guides/internationalization.mdx;./src/content/docs/!(en)/reference/configuration-reference.mdx;./src/content/docs/!(en)/guides/internationalization.mdx

@ematipico @yanthomasdev @sarah11918
feat(i18n): manual routing (#7749)
fa276a5 
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@sarah11918 sarah11918 added this to the 4.6.0 milestone Apr 10, 2024
@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Apr 10, 2024
@astrobot-houston
Copy link
Contributor

astrobot-houston commented Apr 10, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note Locale
src/content/docs/en/guides/dev-toolbar.mdx Source changed, localizations will be marked as outdated. en
src/content/docs/en/guides/internationalization.mdx Source changed, localizations will be marked as outdated. en
src/content/docs/en/install/auto.mdx Source changed, localizations will be marked as outdated. en
src/content/docs/en/reference/api-reference.mdx Source changed, localizations will be marked as outdated. en
src/content/docs/en/reference/configuration-reference.mdx Source changed, localizations will be marked as outdated. en
src/content/docs/en/reference/dev-toolbar-app-reference.mdx Source changed, localizations will be marked as outdated. en
src/content/docs/en/reference/error-reference.mdx Source changed, localizations will be marked as outdated. en
src/content/docs/en/reference/errors/incorrect-strategy-for-i18n.mdx Source added, will be tracked. en
src/content/docs/en/reference/errors/missing-middleware-for-internationalization.mdx Source added, will be tracked. en
src/content/docs/en/reference/errors/no-prerendered-routes-with-domains.mdx Source changed, localizations will be marked as outdated. en
src/content/docs/es/reference/configuration-reference.mdx Localization changed, will be marked as complete. es
src/content/docs/ja/reference/configuration-reference.mdx Localization changed, will be marked as complete. ja
src/content/docs/ko/guides/internationalization.mdx Localization changed, will be marked as complete. ko
src/content/docs/zh-cn/reference/configuration-reference.mdx Localization changed, will be marked as complete. zh-cn
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@vercel Vercel
Copy link

vercel bot commented Apr 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Apr 11, 2024 11:52am

@withastro withastro deleted a comment from vercel bot Apr 11, 2024
@ematipico @sarah11918
feat: update minimum Node.js version (#7838)
3ecfa0d 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@sarah11918 sarah11918 merged commit 71de23a into main Apr 11, 2024
8 checks passed
@sarah11918 sarah11918 deleted the 4.6.0 branch April 11, 2024 11:53
This was referenced Apr 11, 2024
Merged
Merged
This was referenced Apr 12, 2024
Closed
Merged
Merged
Merged
Merged
Merged
@GuoJikun GuoJikun mentioned this pull request Apr 12, 2024
Closed
This was referenced Apr 12, 2024
Merged
Merged
Merged
Closed
Merged
Merged
thomasbnt added a commit to thomasbnt/docs that referenced this pull request Apr 14, 2024
@thomasbnt
i18n(fr): Updating `reference/errors/no-prerendered-routes-with-domai…
6abe49b 
…ns.mdx.mdx` from withastro#7846

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
thomasbnt added a commit to thomasbnt/docs that referenced this pull request Apr 14, 2024
@thomasbnt
i18n(fr): Updating install/auto.mdx from withastro#7846
f51a593 
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
thomasbnt added a commit to thomasbnt/docs that referenced this pull request Apr 14, 2024
@thomasbnt
i18n(fr): Updating guides/toolbar.mdx from withastro#7846
e880d36 
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
This was referenced Apr 14, 2024
Merged
Merged
Merged
dreyfus92 added a commit that referenced this pull request Apr 15, 2024
@thomasbnt @MaeWolff @dreyfus92
i18n(fr): Updating guides/toolbar.mdx(#7894)
eb1b2a3 
* i18n(fr): Updating `guides/toolbar.mdx` from #7846

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* Update src/content/docs/fr/guides/dev-toolbar.mdx

Co-authored-by: Maxence <56693082+MaeWolff@users.noreply.github.com>

---------

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Maxence <56693082+MaeWolff@users.noreply.github.com>
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
@mearashadowfax mearashadowfax mentioned this pull request Apr 17, 2024
Merged
This was referenced Apr 18, 2024
Merged
Merged
@at-the-vr at-the-vr mentioned this pull request May 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElianCodes ElianCodes ElianCodes approved these changes

Assignees
No one assigned
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.
7 participants
@sarah11918 @astrobot-houston @ElianCodes @mingjunlu @fshafiee @ematipico @yanthomasdev