Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update minimum Node.js version #7838

Merged
merged 4 commits into from
Apr 11, 2024

Conversation

ematipico
Copy link
Member

Description (required)

This PR updates the minimum Node.js version.

For Astro version: 4.6. See astro PR #10689. -->

Copy link

vercel bot commented Apr 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Apr 11, 2024 11:57am
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Apr 11, 2024 11:57am

@@ -13,7 +13,7 @@ Read our [step-by-step manual installation guide](/en/install/manual/) instead.
:::
#### Prerequisites

- **Node.js** - `v18.14.1` or higher.
- **Node.js** - `v18.17.1` or higher.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if this should precise the full requirements, which is 18.17.1 or higher for 18, not 19, and 20.3.0 or higher for 20.

Copy link
Member Author

@ematipico ematipico Apr 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. If users that are on Node.js v19 now try to install Astro, they will get the engine warning

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied the change in 3a32833 (#7838), I will let Sarah decide on the format of the sentence.

@sarah11918 sarah11918 merged commit 3ecfa0d into 4.6.0 Apr 11, 2024
2 of 3 checks passed
@sarah11918 sarah11918 deleted the feat/update-required-node-js-version branch April 11, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants