Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split API reference into modules #9687

Merged
merged 37 commits into from
Oct 25, 2024
Merged

split API reference into modules #9687

merged 37 commits into from
Oct 25, 2024

Conversation

sarah11918
Copy link
Member

@sarah11918 sarah11918 commented Oct 15, 2024

Description (required)

In an attempt to make the API reference easier to navigate adds a new reference section specifically for the Astro API and each module individually.

Basic infra only! No content changes or improvements attempted! We should use this PR to figure out file name/folder conventions to use! Consistent page titles etc.! No decisions are final!

TRANSLATORS:
I'm sorry that there will still be more work to do after this that will again update the content on some of these pages. And, there is more content changed here than I expected, but most of it is moving content around in sections! You can see the list below for things that I expect to continue to change here, but I did want to get the new pages created first, then we can tackle specific content independently!

  • redirects ? I've kept the name of the main API reference page so in the worst case people aren't getting 404s visiting content that has moved. Is having redirect from section headings to a new page practical?
  • one error message was force overwritten to pass link checks here; will need to be updated at source once we are confident in what changes this pr actually makes PR
  • Page introductions. These were previously sections of a longer page, so they don't really introduce the page nicely at all yet; they start with another heading immediately after the page title etc.
  • Lunaria tracking - some translated pages have had links updated but there should be no other changes needed to those pages, so they should be ignored by the tracker. Only the English pages, and the nav should be tracked.

Summary of notes left open below for follow up work:

  • remove "built in components" page entirely (already duplication now with the <ViewTransitions>, <Image>, and <Picture> components. Instead, content will go to relevant place in docs, perhaps with a new astro:components page
  • assets page needs full documentation of <Image> properties -- copy from guide to start, then actually make proper reference matching the rest of the entries
  • for the imported components, and moving to the Components/Syntax page for things like <Fragment> that are not imported
  • So far, only middleware documents a required export (vs things you import from the module). Other pages could also document exports, but currently don't. For the sake of this PR, we are not adding new entries but will revisit for consistency and can consider adding the "Exports" section to other pages like astro:actions, astro:content etc.
  • sidebar nav huge design means not touching the section headers etc. for Reference. Sidebar will change in current project, so not addressed here
  • Is api-reference still the right name for the "leftover page"? Work is ongoing as we speak to clean up and focus the Runtime API page, so naming not changed here (plus, means we don't need any redirects here because the old page still exists). This particular page will be updated separately.
  • we noticed (by the fact there were no broken links) that the view transitions guide page does not at any point link to the astro:transitions reference. This should make us check that page to make sure it's not doing too much and trying to be reference itself instead of just linking out to reference. (Note, so many things were previously undocumented about the API that it could simply mean that content just wasn't covered in the guide either, so not necessarily a problem, but for sure a smell.)

Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit af5eb10
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/671ba25cc1596a00088d6913
😎 Deploy Preview https://deploy-preview-9687--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sarah11918 sarah11918 added the site improvement Some thing that improves the website functionality - ask @delucis for help! label Oct 15, 2024
@astrobot-houston
Copy link
Contributor

astrobot-houston commented Oct 15, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/actions.mdx Source changed, localizations will be marked as outdated.
en guides/content-collections.mdx Source changed, localizations will be marked as outdated.
en guides/imports.mdx Source changed, localizations will be marked as outdated.
en guides/internationalization.mdx Source changed, localizations will be marked as outdated.
en guides/markdown-content.mdx Source changed, localizations will be marked as outdated.
en guides/middleware.mdx Source changed, localizations will be marked as outdated.
en reference/api-reference.mdx Source changed, localizations will be marked as outdated.
en reference/errors/actions-returned-invalid-data-error.mdx Source changed, localizations will be marked as outdated.
en reference/modules/astro-actions.mdx Source added, will be tracked.
en reference/modules/astro-assets.mdx Source added, will be tracked.
en reference/modules/astro-content.mdx Source added, will be tracked.
en reference/modules/astro-i18n.mdx Source added, will be tracked.
en reference/modules/astro-middleware.mdx Source added, will be tracked.
en reference/modules/astro-transitions.mdx Source added, will be tracked.
en tutorials/add-content-collections.mdx Source changed, localizations will be marked as outdated.
it tutorials/add-content-collections.mdx Localization changed, will be marked as complete.
ja guides/content-collections.mdx Localization changed, will be marked as complete.
ja guides/imports.mdx Localization changed, will be marked as complete. 🔄️
ja guides/middleware.mdx Localization changed, will be marked as complete.
ja reference/configuration-reference.mdx Localization changed, will be marked as complete.
pl guides/imports.mdx Localization changed, will be marked as complete. 🔄️
en nav.ts Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Oct 15, 2024
src/i18n/en/nav.ts Outdated Show resolved Hide resolved
sarah11918 and others added 2 commits October 16, 2024 08:12
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great! Definitely helpful to split these out into the new pages. 🙌

No comment on the Lunaria side of things, but left a couple of notes on things that stood out to me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And while we’re on the subject of title: if we do indeed come up with a better title (and sidebar label?), we may as well also rename the URL to match and add a redirect.

src/content/docs/en/reference/modules/astro-actions.mdx Outdated Show resolved Hide resolved
@sarah11918 sarah11918 marked this pull request as ready for review October 23, 2024 11:19
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the new intros @sarah11918! Left some more notes. Sorry if some of the headings comments slightly contradict what we discussed previously. Going through things in more details made me realise that clearly labelling with module names may be more important than I initially realised (especially for certain pages).

src/content/docs/en/reference/modules/astro-actions.mdx Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don’t want to keep throwing spanners at this very helpful PR, but this page (and how lonely getImage() is on it) is making me wonder about where <Image> and <Picture> are documented.

Right now we have “Built-in Components”, which actually mixes components from a range of sources:

  • astro/components (also available as astro:components) exports <Code>, <Prism>, and <Debug>.
  • astro:assets exports <Image> and <Picture>.
  • astro:transitions exports <ViewTransitions> (being renamed in v5).
  • <Fragment> is not imported at all, it’s more of a language/syntax feature.
  • <Content> can come from all kinds of places (imported Markdown, rendered content collection entries, etc.)

So this is more a note rather than a suggestion in one way or other. Now we document modules explicitly, maybe the components for that module are helpful in that module’s reference? Flipside of course is that the current component page collects all of the above so someone thinking “What are the available components?” can find them, vs someone looking to answer “What’s in astro:assets?”

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is a lonely page indeed! I think now that we're doing this restructuring, it's probably more helpful to have the components in their own module page?

So, maybe we add an astro:components page for those imported components and move the other components to their respective pages? I think <Content /> and <Fragment> are already documented on the Markdown and Components pages respectively as far as syntax and Markdown imports are concerned.

@Fryuni
Copy link
Member

Fryuni commented Oct 23, 2024

It seems a bit weird to me having a "Reference" group and then a bunch of reference pages outside of that group. The word "reference" is also repeated in multiple links, but not all of them so it is inconsistent.

What if we nest them to keep the context and remove the repetition?

Current Nested and shortened
image image

Also changed "Error" to "Errors" to match "Directives" when the reference is about multiple things

@delucis
Copy link
Member

delucis commented Oct 23, 2024

It seems a bit weird to me having a "Reference" group and then a bunch of reference pages outside of that group. The word "reference" is also repeated in multiple links, but not all of them so it is inconsistent.

I agree, but for context, this version of the sidebar is almost certainly a very short-lived iteration. We’re heading in the direction of something more like: https://docs-sidebar-topics.netlify.app/reference/configuration-reference/

sarah11918 and others added 2 commits October 23, 2024 16:14
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Oct 26, 2024
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Oct 26, 2024
yanthomasdev added a commit that referenced this pull request Oct 26, 2024
See #9687

Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
yanthomasdev added a commit that referenced this pull request Oct 26, 2024
See #9687

Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Co-authored-by: thomasbnt <14293805+thomasbnt@users.noreply.github.com>
yanthomasdev added a commit that referenced this pull request Oct 26, 2024
See #9687

Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Co-authored-by: thomasbnt <14293805+thomasbnt@users.noreply.github.com>
yanthomasdev added a commit that referenced this pull request Oct 26, 2024
See #9687

Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Co-authored-by: thomasbnt <14293805+thomasbnt@users.noreply.github.com>
dreyfus92 added a commit that referenced this pull request Oct 27, 2024
See #9687

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
yanthomasdev added a commit that referenced this pull request Oct 28, 2024
See #9687 and #9819

Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Co-authored-by: thomasbnt <14293805+thomasbnt@users.noreply.github.com>
yanthomasdev added a commit that referenced this pull request Oct 28, 2024
See #9687

Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Co-authored-by: thomasbnt <14293805+thomasbnt@users.noreply.github.com>
yanthomasdev added a commit that referenced this pull request Oct 28, 2024
See #9687

Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Co-authored-by: thomasbnt <14293805+thomasbnt@users.noreply.github.com>
yanthomasdev added a commit that referenced this pull request Oct 28, 2024
See #9687 and #9821

Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Co-authored-by: thomasbnt <14293805+thomasbnt@users.noreply.github.com>
yanthomasdev added a commit that referenced this pull request Oct 28, 2024
* i18n(fr): create `reference/modules/astro-assets.mdx`

See #9687 and #9820

* remove extra space

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>

---------

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
yanthomasdev added a commit that referenced this pull request Oct 28, 2024
See #9687

Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Co-authored-by: thomasbnt <14293805+thomasbnt@users.noreply.github.com>
yanthomasdev added a commit that referenced this pull request Oct 28, 2024
See #9687

Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Co-authored-by: thomasbnt <14293805+thomasbnt@users.noreply.github.com>
yanthomasdev added a commit that referenced this pull request Oct 29, 2024
* i18n(fr): create `reference/modules/astro-middleware.mdx`

See #9687

* translate comment

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>

* translate missing sentence

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>

---------

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
yanthomasdev added a commit that referenced this pull request Oct 29, 2024
* i18n(fr): update `guides/markdown-content.mdx`

See #9687

* update anchor as well

---------

Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Co-authored-by: thomasbnt <14293805+thomasbnt@users.noreply.github.com>
yanthomasdev added a commit that referenced this pull request Oct 29, 2024
* i18n(fr): create `reference/modules/astro-i18n.mdx`

See #9687

* translate Response

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>

---------

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
yanthomasdev added a commit that referenced this pull request Oct 29, 2024
See #9687

Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! information architecture reorganizes content on the site site improvement Some thing that improves the website functionality - ask @delucis for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants