Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default detox test triggers screenshot taking mechanism, to dev/null, it probably shouldn't trigger anything. #841

Closed
rotemmiz opened this issue Jul 18, 2018 · 1 comment
Closed

Default detox test triggers screenshot taking mechanism, to dev/null, it probably shouldn't trigger anything. #841

rotemmiz opened this issue Jul 18, 2018 · 1 comment
Assignees
@noomorph
Labels
status: accepted type: bug 🐞

Comments

@rotemmiz
Copy link
Member

/usr/bin/xcrun simctl io DDD18C72-F2BC-4DD5-8312-D5E7066C37AB screenshot "/dev/null" is not a valid request, we should not trigger screenshot taking if the default is none and users did not request to record anything.
Moreover, I think (but didn't test) that this command returns exit code 0 on Xcode 9.3, but exit code 2 on Xcode 9.4.

This is related to facebook/react-native#20235
@rotemmiz rotemmiz mentioned this issue Jul 18, 2018
Closed
This was referenced Jul 19, 2018
Closed
Merged
@noomorph

This comment has been minimized.

Sign in to view
noomorph added a commit that referenced this issue Aug 15, 2018
@noomorph
refactor: internal changes to artifacts subsystem in Detox and bugfix…
daa5ea2 
…es (#848)

Resolves #841 
Resolves #856
@lock lock bot locked as resolved and limited conversation to collaborators Aug 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@noomorph noomorph

Labels
status: accepted type: bug 🐞
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rotemmiz @noomorph @d4vidi