Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios, UIView+DetoxUtils): locate top-most window at point. #3145

Merged
merged 5 commits into from
Dec 27, 2021
Merged

fix(ios, UIView+DetoxUtils): locate top-most window at point. #3145

merged 5 commits into from
Dec 27, 2021

Conversation

asafkorem
Copy link
Contributor

@asafkorem asafkorem commented Dec 23, 2021 •
edited
Loading

No description provided.

@asafkorem asafkorem changed the title UIView+DetoxUtils: locate top-most window at point. fix(UIView+DetoxUtils): locate top-most window at point. Dec 23, 2021
@asafkorem asafkorem changed the title fix(UIView+DetoxUtils): locate top-most window at point. fix(ios, UIView+DetoxUtils): locate top-most window at point. Dec 26, 2021
@asafkorem
Copy link
Contributor Author

retest this please

@asafkorem asafkorem marked this pull request as ready for review December 27, 2021 09:21
@asafkorem asafkorem merged commit a30a9f4 into master Dec 27, 2021
@asafkorem asafkorem deleted the feature/fix-hitability-check branch December 27, 2021 09:53
@asafkorem asafkorem mentioned this pull request Dec 27, 2021
Merged
asafkorem added a commit that referenced this pull request Dec 27, 2021
@asafkorem
Revert "Merge pull request #3145 from wix/feature/fix-hitability-check"
57daa45 
This reverts commit a30a9f4, reversing
changes made to a27fedb.
@asafkorem asafkorem mentioned this pull request Dec 27, 2021
Merged
@asafkorem asafkorem mentioned this pull request Oct 2, 2022
Merged
asafkorem added a commit that referenced this pull request Nov 7, 2022
@asafkorem
fix(iOS): improve hittability-check mechanism. (#3620)
e1f66d1 
This change reverts #3150, and adds the following changes (hit-test):
- #3149
- #3145
- #3115

Those changes resolves this issue #2834.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4vidi d4vidi Awaiting requested review from d4vidi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@asafkorem