Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "UIView+DetoxUtils: put thread to sleep." #3149

Merged
merged 1 commit into from
Dec 27, 2021
Merged

Revert "UIView+DetoxUtils: put thread to sleep." #3149

merged 1 commit into from
Dec 27, 2021

Conversation

asafkorem
Copy link
Contributor

@asafkorem asafkorem commented Dec 27, 2021 •
edited
Loading

This PR reverts the commit UIView+DetoxUtils: put thread to sleep before checking view hitability..
It was added temporally for test purposes, and merged by mistake here: #3145.

@asafkorem asafkorem merged commit b30eb6d into master Dec 27, 2021
@asafkorem asafkorem deleted the feature/revert-thread-sleep branch December 27, 2021 10:30
asafkorem added a commit that referenced this pull request Dec 27, 2021
@asafkorem
Revert "Merge pull request #3149 from wix/feature/revert-thread-sleep"
1039d9d 
This reverts commit b30eb6d, reversing
changes made to a30a9f4.
@asafkorem asafkorem mentioned this pull request Dec 27, 2021
Merged
@asafkorem asafkorem mentioned this pull request Oct 2, 2022
Merged
asafkorem added a commit that referenced this pull request Nov 7, 2022
@asafkorem
fix(iOS): improve hittability-check mechanism. (#3620)
e1f66d1 
This change reverts #3150, and adds the following changes (hit-test):
- #3149
- #3145
- #3115

Those changes resolves this issue #2834.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@asafkorem