feat(iOS): support react native new architecture. #4661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asafkorem
force-pushed
the
test/support-react-native-new-arch
branch
2 times, most recently
from
2431a36 to
d8a5d9c
Compare
asafkorem
force-pushed
the
test/support-react-native-new-arch
branch
2 times, most recently
from
e09f58a to
40dde14
Compare
asafkorem
force-pushed
the
test/support-react-native-new-arch
branch
2 times, most recently
from
683edaf to
cc454a6
Compare
asafkorem
force-pushed
the
test/support-react-native-new-arch
branch
from
cc454a6 to
cb35ca8
Compare
asafkorem
force-pushed
the
test/support-react-native-new-arch
branch
from
cb35ca8 to
abb9ae4
Compare
d4vidi
approved these changes
Jan 6, 2025
|
+Add issue to backlog about restoring DatePicker testing w/ new-arch |
asafkorem
force-pushed
the
test/support-react-native-new-arch
branch
from
2677c01 to
0b9b92f
Compare
Done, #4679 |
Sky
reviewed
Jan 6, 2025
| // MARK: - Setup Methods | ||
|
|
||
| private func setupReactNative(with launchOptions: [UIApplication.LaunchOptionsKey: Any]?) { | ||
| let bridge = RCTBridge(delegate: self, launchOptions: launchOptions) |
There was a problem hiding this comment.
Is this fine to manually create Bridge where is New Arch uses Bridgeless mode by default?
There was a problem hiding this comment.
Good point. I'm using the old pattern here.. I might have overlooked it and need to migrate to the RCTAppDelegate class, which should manage both bridgeless mode and the new architecture mode.
I tried to use a custom AppDelegate.swift and to implement the needed logic (since RCTAppDelegate can't be used in Swift) but it doesn't seem to be the right approach here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support RN new-arch on iOS