Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sharedElementTransitions option to showModal and dismissModal #6699

Merged
merged 4 commits into from
Oct 21, 2020
Merged

Add sharedElementTransitions option to showModal and dismissModal #6699

merged 4 commits into from
Oct 21, 2020

Conversation

mrousavy
Copy link
Collaborator

This adds the sharedElementTransitions option to the animations property in showModal and dismissModal .options. Previously it only existed in ScreenTransitionOptions, so push and pop.

This PR requires #6647 to be finished first, since Shared Element Transitions for showModal and dismissModal only work on iOS atm!

@mrousavy
Copy link
Collaborator Author

Thanks @yogevbd , forgot to add the elementTransitions 🤦‍♂️

@guyca guyca merged commit 33150d9 into master Oct 21, 2020
@guyca guyca deleted the fix-showmodal-dismissmodal-sharedelements-animations branch October 21, 2020 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yogevbd yogevbd yogevbd approved these changes

Assignees
No one assigned
Labels
feature: Shared Element Transition type: accepted/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrousavy @yogevbd @danilobuerger @guyca