Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sharedElementTransitions option to showModal and dismissModal #6699

Merged
merged 4 commits into from
Oct 21, 2020
Merged

Add sharedElementTransitions option to showModal and dismissModal #6699

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d6a93ad
Add `sharedElementTransitions` option to `showModal` and `dismissModal`
mrousavy Oct 20, 2020
1501f97
Add elementTransitions to ModalAnimationOptions
yogevbd Oct 21, 2020
bcf48b8
Merge branch 'master' into fix-showmodal-dismissmodal-sharedelements-…
guyca Oct 21, 2020
2f06d07
Merge branch 'master' into fix-showmodal-dismissmodal-sharedelements-…
guyca Oct 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions lib/src/interfaces/Options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1094,6 +1094,17 @@ export interface ViewAnimationOptions extends ScreenAnimationOptions {
id?: string;
}

export interface ModalAnimationOptions extends ViewAnimationOptions {
/**
* Animations to be applied on elements which are shared between the appearing and disappearing screens
*/
sharedElementTransitions?: SharedElementTransition[];
/**
* Animations to be applied on views in the appearing or disappearing screens
*/
elementTransitions?: ElementTransition[];
}

/**
* Used for describing stack commands animations.
*/
Expand Down Expand Up @@ -1152,11 +1163,11 @@ export interface AnimationOptions {
/**
* Configure what animates when modal is shown
*/
showModal?: ViewAnimationOptions;
showModal?: ModalAnimationOptions;
/**
* Configure what animates when modal is dismissed
*/
dismissModal?: ViewAnimationOptions;
dismissModal?: ModalAnimationOptions;
}

/**
Expand Down