-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1-01-05 new entries and revision for hydrology domain #295
Comments
@juan - reach out to team members to discuss these particular questions |
1-01-05 hydrological domain - draft.ods |
I recommend that prior to submission/any further review, there is a review of whether these are indeed new terms, or already in the code lists; could this review be a necessary step prior to initiating a new item? it may make for a more efficient review process, especially when the list is long. |
@jbianchi81 will work with Johanna Karhonen and JET-HYMON to finalize proposal. It may not be ready for FT22-1. |
An expert team of hydrologists has been formed to finalize the proposal. The goal is to deliver a reduced list of non-controversial terms for FT22-1, and then to continue working on the rest. |
Proposal updated (see first comment) |
This proposal looks well thought out. It would be helpful to organize into 3 tables.
|
These are the variables exisiting already in WMDR containing the words "soil" or "lake", for which there are potential conflicts with the new proposal:
|
Updated according to proposal at #295. First column indicates whether it is a revision of an existing term, a new term or the keeping of an exsting term unmodified
Branch updated. The first column indicates whether it is a revision, addition or keeping of an existing term |
There is a likely conflict between the new proposed variable
|
@JohnEyre -- We discussed this in the last meeting, saying that we are moving towards a more atomic model in which the geometry should be excluded from the variable name (and should be specified using the geometry property). But during the transition both approaches may coexist (the new one would be a broader concept that encompasses the two old ones). |
@jbianchi81 -- I agree. But in the meantime, I suggest we should try to keep all the soil moisture variables as consistent as they can be. Given the existing variables (at the surface, and in the root region), which layer is the new proposed variable representing? Is it the avrage soil moisture in a (thicker) layer. If so, which layer? Also can we drop "content" from the name? (They are all "soil moisture contents" but the word "content" appears to be redundant. Also note the difference in units, which should be avoided if possible. |
Entries 527 and 528 appear to cover the soil moisture for the entire soil region (it would appear that 528 is included in 527). So I question @jbianchi81 if a new variable 'soil moisture' is even needed at this point. If indeed so, I agree with @JohnEyre that 'content' can be dropped. The description of 527 should be revised IMHO by removing '3D field of the'. There may be a requirement for 3D field listed in OSCAR/Requirements, but more generally, observations of 'soil moisture' can in principle be of geometry point, profile, area or volume. @jbianchi81 Please add definitions to existing elements where they are missing. |
I agree that "3D field" is wrong - both 527 and 528 are, by implication, 2D fields although this does not need to be stated in the definition. From the perspective of OSCAR/Requirements, these are separate 2D fields - one "in the roots region" and one higher up ("at surface"). The vertical location of each is a little imprecise, and I could take this issue back to users if you wish. |
I did an initial consistency check for hydrological variables. There was two stylistic ways to express groundwater; groundwater and ground water - > should be coherent way? Some first letter lower case ->Upper case issue suggestions to be coherent: And for consistency to avoid commas in variable names 12266 Storage is linked in path to ground water, but definition includes surface water aspects as well. I will have one more look when @jbianchi81 has updated the table. |
@jkorhonen -- Thanks for the revision. I updated the table in the issue summary to inform which entries are being edited or added. Please proceed to introduce your suggested changes concerning stylistic consistency. |
I support 'groundwater' in one word. Also 'Stream surface velocity'. |
@joergklausen I do not have any additional points to raise in addition to stylistic things mentioned earlier. Consistency check done on my side. |
|
|
https://github.com/wmo-im/wmds/wiki/2022-05-31-TT-WIGOSMD-23 notes:
|
@joergklausen -- branch updated. |
@joergklausen -- branch updated. |
@joergklausen please validate |
@amilan17 Branch validated, I couldn't find anything wrong. |
ready for FT |
Summary and Purpose
To revise existing and add new terms useful for hydrology.
Stakeholder(s)
The hydrological community, WHOS
Proposal
Final Update 9 June 2022
REVISE
Ground water(amount per unit area)Ground water (level)Map of the height of the lake surface.Riverdischargeoftime. [Based on 'discharge' in International Glossary of Hydrology (WMO-No. 385). 2012 edition.]River stage (level above reference)Sub-soil 3D field of the fractionalcontent of water in a volume of wet soil. Typically, in a layer from the surface down to approximately 3 meters3m.NEW
Update Jun 1 2022
Adjusted reference to recommendations
Update May 18 2022
Fixed columns order
Uploaded into new branch
Update 11 May 2022
Removed references URLs. Added notations to new codes. Ordered by notation
Update 28 Apr 2022
Changed "soil moisture content" to "soil moisture"
Update 17 Feb 2022
This list was submitted to HCP and shared within JET-HYDMON for feedback from the hydrological community. It contains basic variables observed in hydrology, excluding water quality variables. All descriptions are cited from official WMO documents
Reason
[your reasoning why the proposal resolves the issue]
The text was updated successfully, but these errors were encountered: