feat: support None to remove envvars #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
changed the title
|
I got a thumbs up, anyone want to do a review? Nice to have an approval. ;). (This will likely require #815 to be rebased once it's in) |
cjolowicz
approved these changes
Apr 12, 2024
|
Should there be a documentation update for this? |
Closed
|
I did add it to the docs. It's only present in nox/sessions.py, but that's the only place |
henryiii
commented
Apr 15, 2024
Comment on lines
+353
to
+355
| command. By default, all environment variables are passed. You | ||
| can block an environment variable from the outer environment by | ||
| setting it to None. |
There was a problem hiding this comment.
Docs update here.
There was a problem hiding this comment.
Ah, I do see it in https://nox.thea.codes/en/stable/config.html#nox.sessions.Session.run. Sorry about the noise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #804. Setting
env={"NOCOLOR": None}will unset the value if it exists in the outer environment.