feat: use static arguments instead of **kwargs #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
changed the title
cjolowicz
approved these changes
Apr 12, 2024
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/feat/staticargs
branch
from
6f3c8f8 to
561f23c
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #813. This provides better documentation, better signatures, and better static typing. This doesn't change too rapidly, so using
**isn't that helpful.**is best for things that can't be determined statically.A few kwargs that previously distinguished between not being passed and being passed now support
None, which is simpler and also a little friendlier for callers.Warning
This removes support for passing keyword arguments through to a function passed into run.
run(f, arg1, kw=kw)is not supported anymore. This does keep support forrun(f, arg1). There's very little reason to ever do this, as it just runs the function for you with a smidge of logging. It's listed in the comment as a legacy feature. It was a little buggy before too, withenv=for example being swallowed.