Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace moment.js #339

Closed
mojoaxel opened this issue Oct 6, 2020 · 7 comments
Closed

replace moment.js #339

mojoaxel opened this issue Oct 6, 2020 · 7 comments
Assignees
@mojoaxel @jamessral
Labels
Enhancement good first issue For beginners Hacktoberfest Project setup Dependencies, libraries, frameworks

Comments

@mojoaxel
Copy link
Member

mojoaxel commented Oct 6, 2020 •
edited by johnjohndoe
Loading

moment.js is deprecated. You should move to another library..

TODOs

  • Explain in this issue which alternative library is suitable and why. Is it well maintained? Pros & cons.
@johnjohndoe johnjohndoe added the Project setup Dependencies, libraries, frameworks label Oct 6, 2020
@jamessral
Copy link
Contributor

I could replace it with date-fns if you would like

@johnjohndoe
Copy link
Member

@mojoaxel Can you please moderate this issue? I do not have time these days.

@mojoaxel
Copy link
Member Author

mojoaxel commented Oct 6, 2020

I could replace it with date-fns if you would like

@jamessral date-fns look fine to me. Day.js would be even easier because it has a compatible api. Feel free choose a suitable alternative an provide a pull-request, I'll be happy to review it!

@mojoaxel mojoaxel self-assigned this Oct 6, 2020
@jamessral
Copy link
Contributor

@mojoaxel The pros for date-fns are:

  • It is one of the recommended libraries by the Moment project
  • It is very modular and designed to be easy for code-splitting
  • It uses an immutable API
  • It has great docs
  • It has good TS support

@jamessral
Copy link
Contributor

I can also look into Day.js for sure.

@jamessral
Copy link
Contributor

jamessral commented Oct 6, 2020 •
edited
Loading

Day also looks quite good. I can work on converting this over to Day.js. Would you mind adding me as an assignee as well?

jamessral added a commit to jamessral/wo-ist-markt.github.io that referenced this issue Oct 6, 2020
@jamessral
Issue wo-ist-markt#339 Swap Moment JS for Day JS
3e1fa44
mojoaxel added a commit that referenced this issue Oct 6, 2020
@mojoaxel
Merge pull request #343 from jamessral/convert-to-dayjs
1727ba9 
Issue #339 Swap Moment JS for Day JS
@mojoaxel
Copy link
Member Author

mojoaxel commented Oct 6, 2020

fixed by @jamessral with #343 🎉

@mojoaxel mojoaxel closed this as completed Oct 6, 2020
mojoaxel pushed a commit to mojoaxel/wo-ist-markt.github.io that referenced this issue Oct 18, 2020
@jamessral @mojoaxel
Issue wo-ist-markt#339 Swap Moment JS for Day JS
35a36c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mojoaxel mojoaxel

@jamessral jamessral

Labels
Enhancement good first issue For beginners Hacktoberfest Project setup Dependencies, libraries, frameworks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@johnjohndoe @mojoaxel @jamessral