Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #339 Swap Moment JS for Day JS #343

Merged
merged 2 commits into from
Oct 6, 2020
Merged

Issue #339 Swap Moment JS for Day JS #343

merged 2 commits into from
Oct 6, 2020

Conversation

jamessral
Copy link
Contributor

Get rid of Moment, use DayJS along with the following included plugins:

  • isBetween (instead of moment-range)
  • isoWeek

mojoaxel
mojoaxel requested changes Oct 6, 2020
View reviewed changes
validation/markets-validator.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@jamessral jamessral requested a review from mojoaxel October 6, 2020 18:10
mojoaxel
mojoaxel approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@mojoaxel mojoaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 Thanks!

@mojoaxel mojoaxel merged commit 1727ba9 into wo-ist-markt:master Oct 6, 2020
@mojoaxel mojoaxel mentioned this pull request Oct 6, 2020
Closed
@johnjohndoe johnjohndoe added the Project setup Dependencies, libraries, frameworks label Oct 6, 2020
@johnjohndoe
Copy link
Member

💡 We could probably replace Moment.js with Day.js in the compile-berlin-geojson.js, too.

@mojoaxel mojoaxel mentioned this pull request Oct 12, 2021
Merged
@johnjohndoe johnjohndoe mentioned this pull request Nov 22, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnjohndoe johnjohndoe johnjohndoe left review comments

@mojoaxel mojoaxel mojoaxel approved these changes

Assignees

@mojoaxel mojoaxel

Labels
Project setup Dependencies, libraries, frameworks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamessral @johnjohndoe @mojoaxel