Fix not ignoring date errors when VERIFY_SKIP_DATE is set #6181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobBarthelmeh
requested changes
Mar 10, 2023
Contributor
JacobBarthelmeh
left a comment
JacobBarthelmeh
left a comment
There was a problem hiding this comment.
We need some regression tests added for these issues.
4 tasks
kareem-wolfssl
assigned
JacobBarthelmeh and
kareem-wolfssl and unassigned
kareem-wolfssl and
JacobBarthelmeh
Contributor
Author
Added unit test for absolute URN case. |
Contributor
|
Please update the renewcerts.sh script in this PR too for the new certificate. The goal is that running that one script updates all of the certificates in ./certs directory. |
Contributor
Author
|
Woops, had that updated but git lost track of it. Fixed. |
JacobBarthelmeh
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix not ignoring date errors when VERIFY_SKIP_DATE is set
Fix unit test failure when building OPENSSL_EXTRA without HAVE_EXT_CACHE.
Allow alternative absolute URI syntax in certificate general name.
Fixes zd# 15767 15773 15751
Testing
Built in tests
Checklist