-
Notifications
You must be signed in to change notification settings - Fork 923
Adding NO_ASN_TIME_CHECK build option #6185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We have the VERIFY_SKIP_DATE option, could that be expanded to OCSP checks, allowing us to avoid adding another macro? |
That looks like it's going to involve duplicating |
dgarske
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the PR. Please add some additional comments in asn.c for NO_ASN_TIME_CHECK to describe the other options for accomplishing this. I'd prefer they use one of the existing supported methods. Also indicate the possible security risk using it.
Over to @SparkiDev for additional feedback.
wolfcrypt/src/asn.c
Outdated
| ret = PaseCRL_CheckSignature(dcrl, buff, cm); | ||
| } | ||
|
|
||
| (void)verify; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already this line above WOLFSSL_MSG.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching that. I opened the PR before that was added.
Description
Skip all time checking without having to define
NO_ASN_TIME. Originally developed as workaround for the issue addressed by #6181, but still a nice feature to have.Fixes zd#15790
Testing
Tested with certs in
certs/test/expired/Checklist