Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the test/docs pipeline to everything that passes #41325

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

murraybd
Copy link
Member

@murraybd murraybd commented Feb 4, 2025

I tested these all on a workstation and the tests passed for every package.

@murraybd murraybd requested a review from a team as a code owner February 4, 2025 23:35
@murraybd murraybd enabled auto-merge (squash) February 4, 2025 23:38
@murraybd murraybd requested a review from a team February 4, 2025 23:39
@dustinkirkland
Copy link
Member

Nice!!

@debasishbsws
Copy link
Member

Since there is no epoch bump in any package, the test has not been triggered in CI. Our initial plan was to batch update these changes along with an epoch bump.
@murraybd, if you confirm that everything looks good, merging this should also work.
@OddBloke, any thoughts on this?

@OddBloke
Copy link
Member

OddBloke commented Feb 5, 2025

Since there is no epoch bump in any package, the test has not been triggered in CI. Our initial plan was to batch update these changes along with an epoch bump. @murraybd, if you confirm that everything looks good, merging this should also work. @OddBloke, any thoughts on this?

We had an internal discussion and decided this was an appropriate path forward: @murraybd has only proposed changes which already pass in local Docker runner testing, so this shouldn't result in any regressions once landed.

@murraybd murraybd merged commit 73071ac into wolfi-dev:main Feb 5, 2025
16 checks passed
@smoser
Copy link
Member

smoser commented Feb 20, 2025

this regressed #43212 .

@smoser
Copy link
Member

smoser commented Feb 20, 2025

Since there is no epoch bump in any package, the test has not been triggered in CI. Our initial plan was to batch update these changes along with an epoch bump. @murraybd, if you confirm that everything looks good, merging this should also work. @OddBloke, any thoughts on this?

We had an internal discussion and decided this was an appropriate path forward: @murraybd has only proposed changes which already pass in local Docker runner testing, so this shouldn't result in any regressions once landed.

It feels to me like we should not be able to make changes that don't have c-i run on them.
That leaves at least 2 options

  1. bump epoch is required, you build and test.
  2. fix c-i to run test any time a package changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants