Skip to content

Conversation

@octo-sts
Copy link
Contributor

@octo-sts octo-sts bot commented Mar 28, 2025

Signed-off-by: wolfi-bot <121097084+wolfi-bot@users.noreply.github.com>
@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr labels Mar 28, 2025
@octo-sts octo-sts bot added bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. auto-approver-bot/initial-checks-failed labels Mar 28, 2025
@Dentrax
Copy link
Member

Dentrax commented Mar 29, 2025

BLOCKed by #48555

Dentrax added 2 commits March 29, 2025 22:48
Signed-off-by: Dentrax <furkan.turkal@chainguard.dev>
Signed-off-by: Dentrax <furkan.turkal@chainguard.dev>
@Dentrax
Copy link
Member

Dentrax commented Mar 29, 2025

@OddBloke Hey - it seems we pinned 2.27.2 version for pydantic-core package but tests fails since it expects latest version: https://github.com/pydantic/pydantic/blob/6c38dc93f40a47f4d1350adca9ec0d72502e223f/pydantic/version.py#L71

Package bump ready to go but test fails. PTAL!

@Dentrax Dentrax requested a review from OddBloke March 29, 2025 20:25
@Dentrax Dentrax self-assigned this Mar 29, 2025
@OddBloke
Copy link
Member

@OddBloke Hey - it seems we pinned 2.27.2 version for pydantic-core package but tests fails since it expects latest version: https://github.com/pydantic/pydantic/blob/6c38dc93f40a47f4d1350adca9ec0d72502e223f/pydantic/version.py#L71

@Dentrax It doesn't expect the latest, that's why we have the check in place: they expect the exact pinned version to be used (and we've seen regressions previously when using the latest).

Package bump ready to go but test fails. PTAL!

The superseded PR contains the fix for this, so take a look over there!

@octo-sts octo-sts bot closed this Apr 3, 2025
@octo-sts
Copy link
Contributor Author

octo-sts bot commented Apr 3, 2025

superseded by #48954

@octo-sts octo-sts bot deleted the wolfictl-3df399f4-ad2e-419a-95c8-51e5620d688f branch April 4, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-approver-bot/initial-checks-failed automated pr bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. manual/review-needed request-version-update request for a newer version of a package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants