Skip to content

Conversation

@Dentrax
Copy link
Member

@Dentrax Dentrax commented Mar 29, 2025

Needed by pydantic:

Fixes:

Related:

Pre-review Checklist

For new package PRs only

  • This PR is marked as fixing a pre-existing package request bug
    • Alternatively, the PR is marked as related to a pre-existing package request bug, such as a dependency
  • REQUIRED - The package is available under an OSI-approved or FSF-approved license
  • REQUIRED - The version of the package is still receiving security updates
  • This PR links to the upstream project's support policy (e.g. endoflife.date)

For new version streams

  • The upstream project actually supports multiple concurrent versions.
  • Any subpackages include the version string in their package name (e.g. name: ${{package.name}}-compat)
  • The package (and subpackages) provides: logical unversioned forms of the package (e.g. nodejs, nodejs-lts)
  • If non-streamed package names no longer built, open PR to withdraw them (see WITHDRAWING PACKAGES)

For package updates (renames) in the base images

When updating packages part of base images (i.e. cgr.dev/chainguard/wolfi-base or ghcr.io/wolfi-dev/sdk)

  • REQUIRED cgr.dev/chainguard/wolfi-base and ghcr.io/wolfi-dev/sdk images successfully build
  • REQUIRED cgr.dev/chainguard/wolfi-base and ghcr.io/wolfi-dev/sdk contain no obsolete (no longer built) packages
  • Upon launch, does apk upgrade --latest successfully upgrades packages or performs no actions

For security-related PRs

  • The security fix is recorded in the advisories repo

For version bump PRs

  • The epoch field is reset to 0

For PRs that add patches

  • Patch source is documented

@octo-sts
Copy link
Contributor

octo-sts bot commented Mar 29, 2025

⚠️ EXPERIMENTAL

Please use 👍 or 👎 on this comment to indicate if you agree or disagree with the recommendation.

To provide more detailed feedback please comment on the recommendation prefixed with /ai-verify:

e.g. /ai-verify partially helpful but I also added bash to the build environment

Gen AI suggestions to solve the build error:

• Detected Error: "fatal: Remote branch 0.4.0 not found in upstream origin"

• Error Category: Version/Git Checkout

• Failure Point: Git checkout step attempting to fetch tag '0.4.0'

• Root Cause Analysis: The build is failing because the git checkout step cannot find the specified tag '0.4.0' in the repository. Looking at the repository, tags use 'v' prefix.

• Suggested Fix:

  1. Modify the pipeline section in the YAML to use the correct tag format:
pipeline:
  - uses: git-checkout
    with:
      expected-commit: 34ce565809b97af7782144b88092a197a05a274d
      repository: https://github.com/pydantic/typing-inspection
      tag: v${{package.version}}

• Explanation: The upstream repository uses 'v' prefixed tags (e.g., 'v0.4.0' instead of '0.4.0'). Adding the 'v' prefix will allow the git checkout to find the correct tag.

• Additional Notes:

  • This is a common pattern in Python packages where the version number in setup.py/pyproject.toml differs from the git tag format
  • The expected-commit hash appears correct, matching the v0.4.0 tag
  • The package version (0.4.0) is correct, just the git tag reference needs adjustment

• References:

@octo-sts octo-sts bot added the ai/skip-comment Stop AI from commenting on PR label Mar 29, 2025
@Dentrax Dentrax force-pushed the py3-typing-inspection branch from 7b0d6e3 to a89f093 Compare March 29, 2025 11:47
Signed-off-by: Dentrax <furkan.turkal@chainguard.dev>
@Dentrax Dentrax force-pushed the py3-typing-inspection branch from a89f093 to 7616ab9 Compare March 29, 2025 12:00
@octo-sts octo-sts bot added the bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. label Mar 29, 2025
@Dentrax Dentrax marked this pull request as ready for review March 29, 2025 12:34
@imjasonh imjasonh merged commit fd11439 into wolfi-dev:main Mar 29, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai/skip-comment Stop AI from commenting on PR bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants