Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement cloudstack datacenter config validator #8

Draft
wants to merge 7 commits into
base: update-cloudstack-template-to-support-failure-domains
Choose a base branch
from

Conversation

wongni
Copy link
Owner

@wongni wongni commented Jul 20, 2022

Issue #, if available:
aws#2406

Description of changes:
Implemented CloudStack DataCenter Config's validator

Testing (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

Merging #8 (9636448) into update-cloudstack-template-to-support-failure-domains (105ab17) will increase coverage by 0.04%.
The diff coverage is 87.50%.

@@                                    Coverage Diff                                    @@
##           update-cloudstack-template-to-support-failure-domains       #8      +/-   ##
=========================================================================================
+ Coverage                                                  59.64%   59.68%   +0.04%     
=========================================================================================
  Files                                                        318      318              
  Lines                                                      26058    26077      +19     
=========================================================================================
+ Hits                                                       15543    15565      +22     
+ Misses                                                      9202     9198       -4     
- Partials                                                    1313     1314       +1     
Impacted Files Coverage Δ
pkg/cluster/cloudstack.go 57.89% <0.00%> (-3.93%) ⬇️
...g/api/v1alpha1/cloudstackdatacenterconfig_types.go 65.06% <100.00%> (+9.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 105ab17...9636448. Read the comment docs.

@wongni wongni force-pushed the update-cloudstack-template-to-support-failure-domains branch from 105ab17 to e648699 Compare July 20, 2022 18:22
chrisnegus and others added 6 commits July 20, 2022 16:04
* Add note: Docker desktop not supported for bare metal

* Minor wording change
* Support snow upgrade from beta with different naming format

* Add snow ChangeDiff

* Fix bug, add unit tests

* Introduce IncrementNameWithFallbackDefault

* Change log level
…1beta2 API (aws#2771)

* Update the cloudstack templates to support failure domains and CAPC v1beta2 API

* Move cloudstack datacenter setDefaults to Defaulters
Pull a method filling proxy configurations
@wongni wongni force-pushed the implement-cloudstack-datacenter-config-validator branch from 9636448 to 83a0273 Compare July 21, 2022 22:38
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants