forked from aws/eks-anywhere
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement cloudstack datacenter config validator #8
Draft
wongni
wants to merge
7
commits into
update-cloudstack-template-to-support-failure-domains
Choose a base branch
from
implement-cloudstack-datacenter-config-validator
base: update-cloudstack-template-to-support-failure-domains
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Implement cloudstack datacenter config validator #8
wongni
wants to merge
7
commits into
update-cloudstack-template-to-support-failure-domains
from
implement-cloudstack-datacenter-config-validator
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## update-cloudstack-template-to-support-failure-domains #8 +/- ##
=========================================================================================
+ Coverage 59.64% 59.68% +0.04%
=========================================================================================
Files 318 318
Lines 26058 26077 +19
=========================================================================================
+ Hits 15543 15565 +22
+ Misses 9202 9198 -4
- Partials 1313 1314 +1
Continue to review full report at Codecov.
|
wongni
force-pushed
the
update-cloudstack-template-to-support-failure-domains
branch
from
July 20, 2022 18:22
105ab17
to
e648699
Compare
* Add note: Docker desktop not supported for bare metal * Minor wording change
* Support snow upgrade from beta with different naming format * Add snow ChangeDiff * Fix bug, add unit tests * Introduce IncrementNameWithFallbackDefault * Change log level
…1beta2 API (aws#2771) * Update the cloudstack templates to support failure domains and CAPC v1beta2 API * Move cloudstack datacenter setDefaults to Defaulters Pull a method filling proxy configurations
wongni
force-pushed
the
implement-cloudstack-datacenter-config-validator
branch
from
July 21, 2022 22:38
9636448
to
83a0273
Compare
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws#2406
Description of changes:
Implemented CloudStack DataCenter Config's validator
Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.