Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: add aria-label on breadcrumbs #1668

Merged
merged 5 commits into from
May 5, 2021
Merged

Accessibility: add aria-label on breadcrumbs #1668

merged 5 commits into from
May 5, 2021

Conversation

radex02
Copy link
Contributor

@radex02 radex02 commented Apr 30, 2021

Improves accessibility of the breadcrumbs

Added aria-label="breadcrumbs" on the breadcrumb's <nav>

@radex02 radex02 requested a review from a team as a code owner April 30, 2021 20:22
@radex02 radex02 requested review from Aljullu and removed request for a team April 30, 2021 20:22
@radex02 radex02 marked this pull request as draft May 1, 2021 16:24
@radex02 radex02 marked this pull request as ready for review May 1, 2021 16:41
@mikejolley
Copy link
Member

mikejolley commented May 5, 2021

Thanks for contributing @radex02 - this looks like a useful enhancement. I did push a fix to fix the 'textdomain' which needs to be wrapped in quotes, and an escaping function to ensure it's safe.

In future, it would be great to also include testing instructions and confirm your PR is tested. In this case there would have been a syntax error due to the textdomain.

Testing instructions

  1. View page on the frontend with a breadcrumb, for example, the shop page
  2. Inspect source and confirm the nav element has an aria label.

Thanks

@mikejolley mikejolley added this to the 3.6.0 milestone May 5, 2021
@mikejolley mikejolley merged commit 68e0a91 into woocommerce:trunk May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants