Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: add aria-label on breadcrumbs #1668

Merged
merged 5 commits into from
May 5, 2021
Merged

Accessibility: add aria-label on breadcrumbs #1668

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
73ac09d
Accessibility: add aria-label on breadcrumbs
radex02 Apr 30, 2021
8694a0f
"breadcrumbs" -> "Breadcrumb"
radex02 May 1, 2021
6c97fb1
Localise breadcrumb aria-label
radex02 May 1, 2021
572b5c7
Add escape and fix textdomain
mikejolley May 5, 2021
5a0eb9f
Use esc_attr__
mikejolley May 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion inc/woocommerce/class-storefront-woocommerce.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ public function is_woocommerce_extension_activated( $extension = 'WC_Bookings' )
*/
public function change_breadcrumb_delimiter( $defaults ) {
$defaults['delimiter'] = '<span class="breadcrumb-separator"> / </span>';
$defaults['wrap_before'] = '<div class="storefront-breadcrumb"><div class="col-full"><nav class="woocommerce-breadcrumb">';
$defaults['wrap_before'] = '<div class="storefront-breadcrumb"><div class="col-full"><nav class="woocommerce-breadcrumb" aria-label="' . esc_attr__( 'breadcrumbs', 'storefront' ) . '">';
$defaults['wrap_after'] = '</nav></div></div>';
return $defaults;
}
Expand Down