Feature/improve polling strategy new stores #9215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can test the changes on this Pull Request by downloading an installable build, or scanning this QR code:
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## trunk #9215 +/- ##
============================================
- Coverage 44.29% 44.29% -0.01%
- Complexity 4250 4251 +1
============================================
Files 854 854
Lines 45108 45111 +3
Branches 5905 5908 +3
============================================
+ Hits 19980 19981 +1
Misses 23382 23382
- Partials 1746 1748 +2
☔ View full report in Codecov by Sentry. |
0nko
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After the Jetpack Sync issues were resolved: pe5sF9-1xN-p2. We decided we can rely back on the values for fields:
jetpack/jetpack_connection/woocommerce_is_active/is_wpcom_storeto check if a site is ready.Moreover, now that we have a notification in place that will inform the user when their store is ready, and given we want to ensure all the previous fields have the expected value before taking the user to My Store tab, we'll increase the timeout threshold to provide more time for the Atomic transfer to run successfully.
Note that after several tests with these new checks, from the moment you tap on "Start Free Trial" button to landing on My Store tab, the user will roughly wait 1 min 10secs.
Testing instructions
Create a few stores using the store creation flow and check that after around 1 min from loading, you are taken to the My store tab and the free trial banner is displayed correctly.