Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/improve polling strategy new stores #9215

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Feature/improve polling strategy new stores #9215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01921e4
Update the checks to determine a new store is ready for use
JorgeMucientes Jun 13, 2023
4c06fae
Increase the loading time for store creation before timing out
JorgeMucientes Jun 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...n/kotlin/com/woocommerce/android/ui/login/storecreation/installation/InstallationConst.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package com.woocommerce.android.ui.login.storecreation.installation

object InstallationConst {
const val STORE_LOAD_RETRIES_LIMIT = 10
const val INITIAL_STORE_CREATION_DELAY = 30000L
const val STORE_LOAD_RETRIES_LIMIT = 15
const val INITIAL_STORE_CREATION_DELAY = 40000L
const val SITE_CHECK_DEBOUNCE = 5000L
}
5 changes: 4 additions & 1 deletion ...in/com/woocommerce/android/ui/login/storecreation/installation/ObserveSiteInstallation.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,10 @@ class ObserveSiteInstallation @Inject constructor(
}

private val SiteModel?.isReadyToUse: Boolean
get() = this?.isJetpackInstalled == true && this.isJetpackConnected
get() = this?.isJetpackInstalled == true &&
this.isJetpackConnected &&
this.isWpComStore &&
this.hasWooCommerce

private fun SiteModel?.isDesynced(expectedName: String): Boolean =
this?.isJetpackInstalled == true && this.isJetpackConnected &&
Expand Down