This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
E2E: Refactor Mini Cart to be ready for fully parallel #10704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woocommercebot
requested review from
a team and
thealexandrelara
and removed request for
a team
dinhtungdu
added
status: needs review
type: refactor
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.43 MB
ℹ️ View Unchanged
|
nielslange
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
Thanks for working on this, @dinhtungdu! I've successfully tested this change and noticed that the tests are superfast when being executed in parallel. Well done! 👏 I hope we can soon activate the parallel execution of all our E2E tests (except the side-effect-related ones). 😀
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
opr
suggested changes
Aug 24, 2023
There was a problem hiding this comment.
The changes to the mini cart test look great, but not super sure about the added utils. We're just re-running tests on #10561 so when they pass, I'll merge it, maybe you can rebase once that's merged and make use of the auth states?
opr
reviewed
Aug 24, 2023
tests/e2e/utils/use-incognito.ts
Outdated
Comment on lines
6
to
17
| const getFreshSession = () => { | ||
| return { | ||
| cookies: [], | ||
| origins: [], | ||
| }; | ||
| }; | ||
|
|
||
| export const useIncognito = ( test: typeof Test ) => { | ||
| test.use( { | ||
| storageState: getFreshSession(), | ||
| } ); | ||
| }; |
There was a problem hiding this comment.
I don't think this abstraction is really necessary. We're adding functions for something that can be done in a single line anyway.
test. use( storageState: { cookies: [], origins: [] } );
Also, the naming implies it's opening an incognito window which may confuse folks in the future, and also since it's using test.use it can only be executed at the describe level, not within a test itself, so it may cause further confusion.
I think we should drop this.
Moreover, in #10561 we are adding auth states, so we can instead do: test.use( { storageState: guestFile } ); to get a guest session.
There was a problem hiding this comment.
Hmm, @dinhtungdu looks like we're not going to get #10561 merged today it seems there's some more work to do on it, so I'd be fine with you skipping waiting for that and just getting it working.
There was a problem hiding this comment.
You're right. I removed the utility and added comment explaining the reason.
About the using the guest file, I think it will prevent tests run in isolation because we're reusing the context. That's why I use an empty object for the state (and was over optimized by using a function to ensure the new object every time). I will verify this again when the @tarhi-saad PR is merged.
As mentioned in the code comment, I think tests should run in isolation by default, so we shouldn't use the storageState file in the main config. We can revisit this topic later when tests can be run in isolation are ready for isolation.
opr
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
Code changes look good! Thanks for taking my feedback into account.
The markdown link checking is due to rate limiting I think, so happy to merge even with that failing.
I think tests should run in isolation by default, so we shouldn't use the storageState file in the main config
You mean in playwright.config.js the STORAGE_STATE there? Yea I agree on that.
kmanijak
pushed a commit
that referenced
this pull request
Aug 25, 2023
imanish003
pushed a commit
that referenced
this pull request
Aug 28, 2023
* Add initial look of Full Grid Product Collection pattern * Refactor textAlign property of Product Button so it uses flex rather than text-align * Update Product Button text align after the fix * Remove debug log (#10719) * Add Product Collection Grid pattern (#10660) * Dispatch the `wc-blocks_render_blocks_frontend` event when rendering the empty cart block (#10619) * E2E: Refactor Mini Cart to be ready for fully parallel (#10704) * Revert dequeue add-to-cart-variation script which is needed to properly handle variable products in single product page (#10723) * Update alignment options to new setting --------- Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com> Co-authored-by: Tung Du <dinhtungdu@gmail.com>
samueljseay
pushed a commit
that referenced
this pull request
Aug 29, 2023
* Add initial look of Full Grid Product Collection pattern * Refactor textAlign property of Product Button so it uses flex rather than text-align * Update Product Button text align after the fix * Remove debug log (#10719) * Add Product Collection Grid pattern (#10660) * Dispatch the `wc-blocks_render_blocks_frontend` event when rendering the empty cart block (#10619) * E2E: Refactor Mini Cart to be ready for fully parallel (#10704) * Revert dequeue add-to-cart-variation script which is needed to properly handle variable products in single product page (#10723) * Update alignment options to new setting --------- Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com> Co-authored-by: Tung Du <dinhtungdu@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR:
useIncognito()util for running tests in isolation.Why
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
tests/e2e/playwright.config.ts:npm run test:e2e tests/e2e/tests/mini-cart/mini-cart.block_theme.spec.ts.WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog