This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Revert dequeue add-to-cart-variation script #10723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly handle variable products in single product page
kmanijak
added
type: bug
woocommercebot
requested review from
a team and
dinhtungdu
and removed request for
a team
|
The release ZIP for this PR is accessible via: TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. Script Dependencies ReportThe
This comment was automatically generated by the |
|
Size Change: 0 B Total Size: 1.43 MB ℹ️ View Unchanged
|
dinhtungdu
approved these changes
Aug 24, 2023
thealexandrelara
approved these changes
Aug 24, 2023
thealexandrelara
deleted the
fix/10702-de-dequeue-add-to-cart-variation-script
branch
thealexandrelara
pushed a commit
that referenced
this pull request
Aug 24, 2023
…ly handle variable products in single product page (#10723)
thealexandrelara
added a commit
that referenced
this pull request
Aug 24, 2023
* Empty commit for release pull request * Fix "On sale" badge class (#10634) * Fix "On sale" badge class for shop * Add class to sale badge * Remove client side navigation from Products beta block (#10636) * Remove client side navigation from Products beta block Changes: - Removed the `add_navigation_id_directive` method and its associated filter. This method previously added a `data-wc-navigation-id` attribute to the query block for client-side navigation, which is no longer required. - Removed the `add_navigation_link_directives` method and its associated filter. This method previously added interactive directives to pagination links inside the Query Pagination block. This specific functionality has been removed as it is no longer needed. - Introduced a new method `mark_block_as_interactive`, which is designed to mark the Product Query as an interactive region so that interactive elements can work inside it. This is achieved using the 'data-wc-interactive' attribute. * add data-wc-interactive to product button block * Remove unnecessary code As we have added `data-wc-interactive` on Product button therefore we don't need to add it in Product Query block. * Boolean attribute doesn't need explicit value equal to true * Skip failing i18n-related E2E tests * Skip failing i18n-related E2E test --------- Co-authored-by: Luigi <gigitux@gmail.com> Co-authored-by: Niels Lange <info@nielslange.de> * Update WooCommerce Blocks brand assets (#10622) * Update testing instructions * Update changelog * Fix version number of testing instructions * Update testing notes * Update testing ZIP file * Update version number * Empty commit for release pull request * Load Interactivity API in `bootstrap.php` (#10657) * load Interactivity API in Bootstrap.php file * fix comment * update visibility function * remove blank line * remove comment * remove logic to not load Interactivity API * Empty commit for release pull request * Add readme file * Update testing instructions * Change versions * Update zip * Update 1092.md * Update 1092.md * Make View Cart link displayed below the Add to Cart button (#10675) * Update testing instructions * Update testing notes * Fix: Made migration migrate block templates in the current theme (#10641) * Fix: Made migration migrate block templates in the current theme * Update src/BlockTemplatesController.php Co-authored-by: Paulo Arromba <17236129+wavvves@users.noreply.github.com> * Move migration and status codes to BlockTemplateMigrationUtils --------- Co-authored-by: Paulo Arromba <17236129+wavvves@users.noreply.github.com> * Fix: sync_endpoint_with_page should use a matching slug if it exists instead of creating a new page (#10640) * Fix/10530 Inconsistent new install behaviour for templates when using block themes (#10608) * Skipped requests regarding WP/WC setup, to avoid issues with the pages not existing yet when migrating page content to templates. * Skipped requests regarding WP-CLI to avoid issues with the pages not existing yet when migrating page content to templates. * Added check for woocommerce_db_version option * Add check for occurred migration to skip template injection * corrected if clause * Update src/BlockTemplatesController.php Co-authored-by: Mike Jolley <mike.jolley@me.com> * Added maintenance mode to migration exception. Added trace value to has_migrated options * Merge with new migration logic. * Set correct post terms for wp_template content * updated comment --------- Co-authored-by: Mike Jolley <mike.jolley@me.com> * Update ZIP file * Update testing notes * Update testing notes * Update testing notes * Update testing notes * Update woocommerce.zip file * Revert "Fix: sync_endpoint_with_page should use a matching slug if it exists instead of creating a new page (#10640)" This reverts commit c68583b. * Update testing notes * Update ZIP file * Update changelog * Empty commit for release pull request * Add changelog to readme.txt * Update plugin version in several files * Revert dequeue add-to-cart-variation script which is needed to properly handle variable products in single product page (#10723) * Add the testing notes for 10.9.3 * Update 1093.md * Fix md lint error --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Alba Rincón <albarin@users.noreply.github.com> Co-authored-by: Manish Menaria <the.manish.menaria@gmail.com> Co-authored-by: Luigi <gigitux@gmail.com> Co-authored-by: Niels Lange <info@nielslange.de> Co-authored-by: Tom Cafferkey <tjcafferkey@gmail.com> Co-authored-by: Karol Manijak <20098064+kmanijak@users.noreply.github.com> Co-authored-by: Mike Jolley <mike.jolley@me.com> Co-authored-by: Paulo Arromba <17236129+wavvves@users.noreply.github.com> Co-authored-by: Alexandre Lara <allexandrelara@gmail.com>
kmanijak
added a commit
that referenced
this pull request
Aug 25, 2023
…ly handle variable products in single product page (#10723)
imanish003
pushed a commit
that referenced
this pull request
Aug 28, 2023
* Add initial look of Full Grid Product Collection pattern * Refactor textAlign property of Product Button so it uses flex rather than text-align * Update Product Button text align after the fix * Remove debug log (#10719) * Add Product Collection Grid pattern (#10660) * Dispatch the `wc-blocks_render_blocks_frontend` event when rendering the empty cart block (#10619) * E2E: Refactor Mini Cart to be ready for fully parallel (#10704) * Revert dequeue add-to-cart-variation script which is needed to properly handle variable products in single product page (#10723) * Update alignment options to new setting --------- Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com> Co-authored-by: Tung Du <dinhtungdu@gmail.com>
samueljseay
pushed a commit
that referenced
this pull request
Aug 29, 2023
* Add initial look of Full Grid Product Collection pattern * Refactor textAlign property of Product Button so it uses flex rather than text-align * Update Product Button text align after the fix * Remove debug log (#10719) * Add Product Collection Grid pattern (#10660) * Dispatch the `wc-blocks_render_blocks_frontend` event when rendering the empty cart block (#10619) * E2E: Refactor Mini Cart to be ready for fully parallel (#10704) * Revert dequeue add-to-cart-variation script which is needed to properly handle variable products in single product page (#10723) * Update alignment options to new setting --------- Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com> Co-authored-by: Tung Du <dinhtungdu@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In this PR I revert dequeing
add-to-cart-variationscript which handles logic of variable products.Fixes #10702
Why
It was dequeued in the PR related to adding Interactivity API to Product Button, but it's actually required to properly display variations and allow adding variable products to Cart.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog